Repository navigation
ci(snyk): record main's tested dependencies with snyk monitor - #1862
Merged
Merged
Conversation
On pushes to main, the weekly run and manual runs, the Snyk workflow now records what it tested as the Snyk project reframe-oss/reframe-ci, so the dashboard tracks those versions and Snyk alerts on new advisories for them. Pull requests are only tested. Docs list the checks main now requires.
✅ Deploy Preview for reframe-os ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
snyk/actions/node@master ran with SNYK_TOKEN from whatever was last pushed to that branch. Pinning the action's commit would not be enough: the action is a wrapper that runs the floating snyk/snyk:node image. Both steps now run that image by digest, with the arguments and environment the action's v1.0.0 action.yml passes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Snyk workflow's
snyk testonly passes or fails; nothing it tests reaches the Snyk dashboard. The GitHub integration's ownpackage.jsonproject reads version ranges, not what's installed.Changes
snyk.ymlrunssnyk monitoron the same generated lockfile, on pushes to main, the weekly run and manual runs. It records the tested dependencies as the Snyk projectreframe-oss/reframe-ci, so the dashboard shows those versions and Snyk emails when a new advisory affects them.success() || failure()), so the snapshot stays current. The existing alert step is unchanged.docs/SECURITY-PIPELINE.mdgets the monitor step and the checksmainnow requires.Required checks on
mainI already updated the
main-protectionruleset through the API; it isn't part of this diff. The required checks are nowbuild,Dependency scan,Dependency policy (bun.lock),Secret scan (gitleaks),Workflow lint (actionlint)andsecurity/snyk (akankshatrehun). Snyk reportssecurity/snykon fork PRs too, andDependency scanis skipped on them, which counts as passing.actionlintpasses.