Treat tag prefixes as literal strings - #49
Merged
Merged
Conversation
Prevent regex metacharacters and sed delimiters in a tag prefix from selecting unintended tags or causing lookup failures.
ps-jay
requested review from
DanielAtanasovski,
HSPm,
beardedsamwise,
fransy26,
guyjacksongit,
gyurikol,
pfvisser and
shahhatreece
and
a balanced review from Copilot
August 10, 2026 05:26
There was a problem hiding this comment.
Pull request overview
Updates tag-prefix handling to treat prefixes literally, resolving #48.
Changes:
- Replaces regex/
sedprefix removal with Bash literal matching. - Adds regression tests for dot and pipe-containing prefixes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
shared.sh |
Implements literal prefix matching and removal. |
tests/test_version-lookup.bats |
Adds regression coverage for metacharacter prefixes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
beardedsamwise
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #48
Replace regex and
sedprefix handling with literal Bash matching so metacharacters and delimiter characters do not select unintended tags or break lookup.Adds regression coverage for dot and pipe-containing prefixes.