fix: stop requiring the drifted redirect-producer fork - #4
Open
JakeSCahill wants to merge 1 commit into
Open
Conversation
Antora's own site-generator already calls the real @antora/redirect-producer unconditionally. docs-extensions-and-macros#273 deletes the hand-rolled fork and its ./extensions/modify-redirects export subpath; this playbook still requires that subpath, so the next Antora build after that version lands would fail with ERR_PACKAGE_PATH_NOT_EXPORTED.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
require: '@redpanda-data/docs-extensions-and-macros/extensions/modify-redirects'line from this repo's Antora playbook.Why
docs-extensions-and-macros#273 deletes the hand-rolled
produce-redirects.jsfork and its./extensions/modify-redirectsexport subpath — Antora's own site-generator already calls the real@antora/redirect-producerunconditionally, so the fork was redundant (and had drifted a real bug: it didn't unpublish self-referential aliases the way upstream does).Once that version is published, any build that still requires the deleted subpath fails immediately with
ERR_PACKAGE_PATH_NOT_EXPORTED, before rendering a single page. This was found by a real Antora build against the full playbook, not just docs-extensions-and-macros' own unit tests (which don't exercise any downstream playbook).Confirmed via
gh apithat this line is still present in six repos today;docs(#1960),cloud-docs(#689), andredpanda-labs(#295) already have this exact fix open. This PR covers this repo.Test plan