Repository navigation
Extend system and bundled native library tests - #447
Merged
Merged
Conversation
omajid
force-pushed
the
system-or-bundled-libraries
branch
5 times, most recently
from
November 5, 2026 16:24
c9afc77 to
6bfd0e4
Compare
omajid
changed the title
omajid
marked this pull request as ready for review
November 5, 2026 17:09
Member
Author
|
Like CI results show, every .NET 10 and 11 package we currently ship fails at least one new test. That's a packaging bug that needs to be fix on the packaging side. |
Add two new tests 1. Test system library declarationso n packages Ensure that, for every library in the VMR, we explicitly bundle it or use the system copy. This means that a new library being introduced, or an existing library being removed upstream would be caught by this and require the package to mark it as bundled or system. Discover native library candidates from the VMR release branch matching the runtime being tested. For each candidate, check direct ELF dependencies resolved outside the .NET installation and bundled provides in installed .NET RPMs. Skip known header-only (eg rapidjson) libraries and non-library directories (eg patches). 2. Verify that all the expected system-libraries are correct Check the expected libraries, including brotli, zstd, and zlib are all linked against the system. Assisted-by: GPT-6.1 Terra <noreply@openai.com>
omajid
force-pushed
the
system-or-bundled-libraries
branch
from
November 5, 2026 22:20
6bfd0e4 to
df086b5
Compare
Member
Author
|
The fixes for .NET 11 should be staged everywhere, except for RHEL 8, already. I have re-targeted the test to require .NET 11. I will extend this to .NET 10 later. |
nicrowe00
reviewed
Nov 11, 2026
| use_preview_copr: true | ||
| - container_image: registry.access.redhat.com/ubi8 | ||
| dotnet_version: "11.0" | ||
|
|
Contributor
There was a problem hiding this comment.
Can we remove .NET 8 and 9 from the matrix too?
Member
Author
There was a problem hiding this comment.
Yeah. Let me do a separate PR for that cleanup.
Contributor
There was a problem hiding this comment.
Why was this deleted? Was it not supposed to be included?
Member
Author
There was a problem hiding this comment.
nicrowe00
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add two new tests
Ensure that, for every library in the VMR, we explicitly bundle it or use the system copy.
This means that a new library being introduced, or an existing library being removed upstream would be caught by this and require the package to mark it as bundled or system.
Discover native library candidates from the VMR release branch matching the runtime being tested. For each candidate, check direct ELF dependencies resolved outside the .NET installation and bundled provides in installed .NET RPMs.
Skip known header-only (eg rapidjson) libraries and non-library directories (eg patches).
Check the expected libraries, including brotli, zstd, and zlib are all linked against the system.
Assisted-by: GPT-6.1 Terra noreply@openai.com