Repository navigation
feat(mtv-warm-cutover): add warm migration cutover - #19
Open
stevefulme1 wants to merge 2 commits into
Open
stevefulme1 wants to merge 2 commits into
stevefulme1 wants to merge 2 commits into
Conversation
spyrexd
requested changes
Apr 17, 2026
spyrexd
left a comment
spyrexd
left a comment
There was a problem hiding this comment.
My review is only on the code. I have not tested functionality.
spyrexd
previously approved these changes
Apr 29, 2026
sabre1041
reviewed
Jul 2, 2026
sabre1041
left a comment
sabre1041
left a comment
Contributor
There was a problem hiding this comment.
Added a few comments after review
| @@ -0,0 +1,77 @@ | |||
| --- | |||
|
|
|||
| - name: _apply_cutover | Check if Cutover Already Defined | |||
Contributor
There was a problem hiding this comment.
There may be a situation where the user might want to adjust the cutover time. Lets just say that they set it for time A in the future and want to bring forward the time to an earlier time to start the migration early.
Maybe we keep the existing logic on by default but allow an overview (globally + at a migration level?)
| - name: _apply_cutover | Wait for Migration to Complete | ||
| when: | ||
| - not (mtv_warm_cutover_already_set | bool) | ||
| - mtv_warm_cutover_verify_complete | bool |
Contributor
There was a problem hiding this comment.
Currently a global variable. Within the mtv_migrate role, the decision to wait at different phases is on each plan. Move to support at the Migration level?
stevefulme1
added a commit
to stevefulme1/openshift_virtualization_migration
that referenced
this pull request
Jul 2, 2026
- Fail on existing cutover instead of silently skipping; add force_cutover option (global + per-migration) to allow override with op:replace patch - Move verify_complete to per-migration level (mirrors mtv_migrate pattern), falling back to global default - Add force_cutover and verify_complete to argument_specs and defaults with full descriptions - Remove already_set guard from wait/verify tasks so forced cutovers also get verified
sabre1041
reviewed
Jul 9, 2026
sabre1041
left a comment
sabre1041
left a comment
Contributor
There was a problem hiding this comment.
Functionality looks good. Just need to resolve the failing test
Contributor
Author
|
CI failure was a transient infrastructure issue — Re-ran the failed jobs and all checks now pass:
All prior review comments have been addressed:
|
2 tasks
stevefulme1
added a commit
to stevefulme1/openshift_virtualization_migration
that referenced
this pull request
Aug 21, 2026
- Fail on existing cutover instead of silently skipping; add force_cutover option (global + per-migration) to allow override with op:replace patch - Move verify_complete to per-migration level (mirrors mtv_migrate pattern), falling back to global default - Add force_cutover and verify_complete to argument_specs and defaults with full descriptions - Remove already_set guard from wait/verify tasks so forced cutovers also get verified
stevefulme1
force-pushed
the
feat/warm-migration-cutover
branch
from
August 21, 2026 14:10
eca8a2c to
19e0b25
Compare
stevefulme1
had a problem deploying
to
external-ci
August 21, 2026 14:10 — with 
GitHub Actions
Failure
GitHub Actions
Failure
stevefulme1
had a problem deploying
to
external-ci
September 20, 2026 14:10 — with
GitHub Actions
Error
GitHub Actions
Error
Add mtv_warm_cutover role and playbook to trigger the cutover phase for warm migrations by patching the Forklift Migration resource's spec.cutover with a timestamp. Supports targeting migrations by name, label selector, or plan name. Includes force_cutover override (global + per-request), optional wait-for-completion with configurable retries/delay, and post-cutover success verification. Resolves: MFG-216
stevefulme1
force-pushed
the
feat/warm-migration-cutover
branch
from
November 11, 2026 14:18
8f65dfc to
8761773
Compare
Contributor
Author
|
@vvaldez @tech2734 @sabre1041 Please approve finallly |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mtv_warm_cutoverrole and playbook to finish warm migrations by triggering the cutover phasespec.cutoverwith a timestamp to initiate the final CBT sync, source VM shutdown, and target VM bootResolves
MFG-216 — Finish warm migration step
Usage
Test plan
yamllintpasses (confirmed)ansible-lint --offlinepasses production profile (confirmed — 0 failures)🤖 Generated with Claude Code