Add --php option to process command to run only PHP rules - #8322
Merged
Conversation
Runs only rules bound to a minimal PHP version, i.e. rules implementing MinPhpVersionInterface. Useful to split a PHP version upgrade from the rest of the rules in a single config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
--phpoption to theprocesscommand, that runs only PHP rules - rules bound to a minimal PHP version, i.e. rules implementingMinPhpVersionInterface.Useful to split a PHP version upgrade from the rest of the rules, without having to maintain a second config:
Example
With a config combining PHP sets and other sets:
Running
vendor/bin/rector process src --dry-runapplies everything:class Demo { - public function run(string $value = null) + public function run(?string $value = null) { - $unused = 1; - return $value; } }Running
vendor/bin/rector process src --php --dry-runkeeps only the PHP version rules:class Demo { - public function run(string $value = null) + public function run(?string $value = null) { $unused = 1; return $value; } }Downgrade rules are not affected, as they do not implement
MinPhpVersionInterface.Like
--onlyand--composer-based, the option narrows the run, so unused skip reporting is disabled to avoid false positives. It is forwarded to workers in parallel runs.