[Configuration] Report explicit error when --only rule exists but is not registered - #8300
Merged
Merged
Conversation
…not registered Instead of "was not found", tell the rule class exists and how to register it.
Drop the PSR-4 filesystem scan for short rule names; resolve only fully qualified class names via ReflectionProvider.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--only SomeRulereported "was not found" even when the rule class exists in the autoloaded code and is only missing fromrector.php. Now the rule class is looked up (FQCN viaReflectionProvider, short name via a scan of Rector PSR-4 dirs) and the error says so explicitly.Before:
After:
Unknown rule names keep the original messages.