[EarlyReturn] Deprecate ChangeOrIfContinueToMultiContinueRector - #8299
Merged
Conversation
Splitting a single || condition into multiple continue ifs makes code longer and harder to read in most cases. Removed from early-return set.
TomasVotruba
force-pushed
the
deprecate-change-or-if-continue
branch
from
August 5, 2026 21:59
5c85c0f to
4acfa67
Compare
TomasVotruba
enabled auto-merge (squash)
August 5, 2026 22:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecates
ChangeOrIfContinueToMultiContinueRectorand drops it from theearly-returnset.Splitting a single
||condition into multiplecontinueifs makes the code longer and harder to follow in most cases - the reader has to mentally re-join the conditions that belong together.The rule did this:
foreach ($cars as $car) { - if ($car->hasWheels() || $car->hasFuel()) { + if ($car->hasWheels()) { + continue; + } + if ($car->hasFuel()) { continue; } $car->setWheel($newCar->wheel); }The original single
ifis the more readable form, so the rule is deprecated instead of kept.