Repository navigation
Render service: a local file answered after its render ended is not thrown - #785
Merged
Merged
Conversation
…hrown With RENDER_FILES set (#777), the page's requests to the download site are answered by a route handler, which Playwright runs itself. A request still being read when its render had ended (timed out, its page closed) was "already handled" when its file arrived; route.fulfill threw, nothing awaited the handler, and the unhandled rejection ended the whole service. The handler now catches it and says it among the render's problems. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
RENDER_FILESset (#777), the page's requests for release files are answered by a Playwright route handler. Playwright runs that handler itself, so nothing awaits its promise. A request still being read when its render had already ended (timed out, its page closed) was "already handled" by the time its file arrived:route.fulfillthrew, the rejection was unhandled, and the whole service exited, failing every render in flight.What changes
fromFilesintools/render/render-core.tscatches a failedfulfilland records it among the render's problems instead of throwing.localAnsweralready turns its own read errors into answers, sofulfillis the only thing that can throw here.Checked
tools/render/render-core.spec.ts: a request answered after its render has ended is recorded and never thrown. It fails on main (unhandled rejection) and passes with the fix.Belongs to no spec here. It was found by pdf-export's spec 001 (its figures step, research R10).
🤖 Generated with Claude Code