chore(deps): move the whole Angular train to 21.2.23 - #218
Open
adamjohnwright wants to merge 6 commits into
Open
adamjohnwright wants to merge 6 commits into
adamjohnwright wants to merge 6 commits into
Conversation
Replaces dependabot's #161, which cannot be merged as it stands. That PR moves eleven Angular packages from 21.2.20 to 21.2.22 and leaves `@angular/platform-browser-dynamic` and `@angular/compiler-cli` behind. Angular's packages peer-depend on one another at **exact** versions, so the result does not resolve: Conflicting peer dependency: @angular/core@21.2.23 peer @angular/core@"21.2.23" from @angular/platform-browser-dynamic@21.2.23 Its checks pass only because CI installs with `--legacy-peer-deps`, which accepts an inconsistent tree. #215 removes that flag; after it, #161 fails honestly. So the train moves together: core, common, compiler, compiler-cli, forms, router, elements, localize, platform-browser and platform-browser-dynamic to 21.2.23, and the CLI train -- cli, ssr, build-angular -- to its own 21.2.23. The lockfile is regenerated from scratch rather than hand-resolved, because a partially-merged lock is what produced the conflict in the first place. It resolves **strictly**: `npm ci --dry-run` with no `--legacy-peer-deps`. Verified: 242 unit tests, types, lint 652, dead code 145, format, a full build, and 49 e2e cases against the resulting build -- interactors, the threshold, the custom-resource dialog, the homepage, content pages and the back button. The diagram is what an Angular bump would break, so it is what was exercised. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces dependabot's #161, which cannot be merged as it stands.
Why #161 cannot be taken
It moves eleven Angular packages from 21.2.20 to 21.2.22 and leaves
@angular/platform-browser-dynamicand@angular/compiler-clibehind. Angular'spackages peer-depend on one another at exact versions, so the result does not
resolve:
Its checks pass only because CI installs with
--legacy-peer-deps. #215 removesthat flag; after it, #161 fails honestly rather than passing on a tree that only
installs when npm is told not to look.
What this does instead
The train moves together — core, common, compiler, compiler-cli, forms, router,
elements, localize, platform-browser, platform-browser-dynamic to 21.2.23, and
the CLI train (cli, ssr, build-angular) to its own.
The diff is large, and deliberately so
package-lock.jsonis regenerated from scratch, not hand-resolved: +7334−8144. A partially-merged lock is what produced the conflict in the first place,
and resolving one by hand is how you get a tree that installs but is not what
anyone described.
The thing to check is not the diff's size but whether it resolves without help:
Verified, not assumed
npm cistrictly, with no--legacy-peer-depsthreshold, the custom-resource dialog, the homepage, content pages, the back
button
The diagram is what an Angular bump would break, so the diagram is what was
exercised.
Closes #161 once merged.
🤖 Generated with Claude Code