test(interactors): stop racing the handler that hides the badges - #216
Merged
Merged
Conversation
This test passed on a retry in CI and was reported as flaky. Retries are set to 2 there, so it went green and nobody saw it. The race: the badges are added to the graph, and the handler that hides them at a zoom where they cannot be read runs afterwards. Reading visibility once could catch the moment in between, when nine badges exist and are still visible. It polls now, both for the badges going away and for them coming back after "Zoom to them" -- the fit and the restyle it triggers are not finished when the click returns either. Run three times with retries off: three passes. Found while auditing for other settings that accept a failure quietly, after --legacy-peer-deps turned out to be doing exactly that. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of four tests currently passing only on retry in CI. Playwright is set to
retries: 2there, so it goes green and nobody sees it.The race
The badges are added to the graph, and the handler that hides them at a zoom
where they cannot be read runs afterwards. Reading visibility once could catch
the moment in between — nine badges present and still visible — and fail.
It polls now, both for the badges going away and for them coming back after "Zoom
to them": the fit and the restyle it triggers are not finished when the click
returns either.
Run three times with
--retries=0: three passes.The other three
Found while auditing for settings that accept a failure quietly, after
--legacy-peer-depsturned out to be doing exactly that (#215). The same runreported these as flaky, and they are not mine to guess at:
download-feedback.spec.ts:212— "says it is working during the wait"back-button.spec.ts:40— "leaves the pathway browser without stepping through tabs first"pathway-browser.spec.ts:171— "the Expression tab renders the Expression Atlas heatmap"Filed separately rather than fixed blind.
🤖 Generated with Claude Code