Repository navigation
Don't clone zeroed out display: none subtrees on every layout pass (#2055) - #59777
Merged
Merged
Conversation
…eact#2055) Summary: zeroOutLayoutRecursively runs for every display: none child on every layout pass of its parent, and called cloneChildrenIfNeeded() at every level of the hidden subtree. When the subtree is shared with an earlier tree, the clone callback fired for every hidden node on every pass, even though zeroing it out again changed nothing. In React Native each of those callbacks is a ShadowNode clone. Skip cloning and recursing into children whose subtree is already zeroed out. configVersion is ignored in that check: it only validates the layout cache, which is empty after zeroing out, and embedders such as React Native set it again when they give a cloned node its config. Reviewed By: javache Differential Revision: D129010903
meta-cla
Bot
added
the
CLA Signed
|
@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D129010903. |
cipolleschi
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
zeroOutLayoutRecursively runs for every display: none child on every
layout pass of its parent, and called cloneChildrenIfNeeded() at every
level of the hidden subtree. When the subtree is shared with an earlier
tree, the clone callback fired for every hidden node on every pass, even
though zeroing it out again changed nothing. In React Native each of
those callbacks is a ShadowNode clone.
Skip cloning and recursing into children whose subtree is already zeroed
out. configVersion is ignored in that check: it only validates the
layout cache, which is empty after zeroing out, and embedders such as
React Native set it again when they give a cloned node its config.
Reviewed By: javache
Differential Revision: D129010903