Repository navigation
Include folly headers directly instead of via folly/dynamic.h (#59766) - #59766
Merged
Merged
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@r-barnes has exported this pull request. If you are a Meta employee, you can view the originating Diff in D128763734. |
…59766) Summary: `folly/dynamic.h` is about to stop including `folly/Format.h`, which transitively provided `<map>`. Include `<map>` directly where these files use `std::map`. Changelog: [Internal] ___ landed-with-radar-review Reviewed By: yfeldblum Differential Revision: D128763734
meta-codesync
Bot
changed the title
r-barnes
force-pushed
the
export-D128763734
branch
from
November 3, 2026 01:38
30113c3 to
ac030c7
Compare
Collaborator
|
This pull request was successfully merged by @r-barnes in d9c05a1 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
folly/dynamic.his about to stop includingfolly/Format.h, which transitively provided<map>. Include<map>directly where these files usestd::map.Changelog: [Internal]
landed-with-radar-review
Reviewed By: yfeldblum
Differential Revision: D128763734