Repository navigation
Remove $FlowExpectedError[sketchy-null-string] (utils.js) (#59765) - #59765
Merged
Merged
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@jcperez-ch has exported this pull request. If you are a Meta employee, you can view the originating Diff in D128806028. |
Summary: Replace `commandResult.stdout || '(empty)'` and `commandResult.stderr || '(empty)'` with explicit null-or-empty checks, and remove their `$FlowExpectedError[sketchy-null-string]` suppressions. Both fields are `?string`. `x || '(empty)'` falls back only for `undefined`, `null` and `''`; `x == null || x === '' ? '(empty)' : x` falls back for exactly those values and keeps every other string, including whitespace. The header line, `stdout` and `stderr` are each read once, in the original order. Changelog: [Internal] Differential Revision: D128806028
meta-codesync
Bot
changed the title
jcperez-ch
force-pushed
the
export-D128806028
branch
from
November 2, 2026 19:45
9583c69 to
8d9a30c
Compare
javache
approved these changes
Nov 3, 2026
javache
left a comment
javache
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Collaborator
|
This pull request was successfully merged by @jcperez-ch in 7a3bcf0 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Replace
commandResult.stdout || '(empty)'andcommandResult.stderr || '(empty)'with explicit null-or-empty checks, and remove their$FlowExpectedError[sketchy-null-string]suppressions.Both fields are
?string.x || '(empty)'falls back only forundefined,nulland'';x == null || x === '' ? '(empty)' : xfalls back for exactly those values and keeps every other string, including whitespace. The header line,stdoutandstderrare each read once, in the original order.Changelog: [Internal]
Differential Revision: D128806028