Repository navigation
Type the LogBox URL matcher's exec result as RegExpExecArray - #59736
Merged
Merged
Conversation
Summary: `LogBoxMessage` stores `regex.exec(...)` results in a local annotated as `RegExp$matchResult`, Flow's alias for `RegExpMatchArray` (the result type of `String#match`). Annotate it with `RegExpExecArray`, the type `exec` returns. That stays correct once `RegExpMatchArray`'s `index` and `input` become optional, as in TypeScript's library. Nothing changes at runtime. Changelog: [Internal] Differential Revision: D128877320
meta-cla
Bot
added
the
CLA Signed
|
@SamChou19815 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D128877320. |
Collaborator
|
This pull request was successfully merged by @SamChou19815 in b23e9a2 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
LogBoxMessagestoresregex.exec(...)results in a local annotated asRegExp$matchResult, Flow's alias forRegExpMatchArray(the result type ofString#match). Annotate it withRegExpExecArray, the typeexecreturns. That stays correct onceRegExpMatchArray'sindexandinputbecome optional, as in TypeScript's library. Nothing changes at runtime.Changelog: [Internal]
Differential Revision: D128877320