Skip to content

Fix a startup crash when an Image is created before Fresco is initialized #59701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomekzaw wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix a startup crash when an Image is created before Fresco is initialized #59701

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
473d246
Wait for Fresco to be initialized before creating the first Image view
tomekzaw Oct 30, 2026
c95cdd5
Merge branch 'main' into fix-fresco-init-race
tomekzaw Nov 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion ...act-native/ReactAndroid/src/main/java/com/facebook/react/views/image/ReactImageManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import com.facebook.react.bridge.ReadableMap
import com.facebook.react.bridge.ReadableType
import com.facebook.react.common.ReactConstants
import com.facebook.react.module.annotations.ReactModule
import com.facebook.react.modules.fresco.FrescoModule
import com.facebook.react.uimanager.BackgroundStyleApplicator
import com.facebook.react.uimanager.LengthPercentage
import com.facebook.react.uimanager.LengthPercentageType
Expand Down Expand Up @@ -92,12 +93,24 @@ public constructor(
?: callerContextFactory?.getOrCreateCallerContext(context.moduleName, null)
return ReactImageView(
context,
draweeControllerBuilder ?: Fresco.newDraweeControllerBuilder(),
draweeControllerBuilder ?: newDraweeControllerBuilder(context),
globalImageLoadListener,
callerContext,
)
}

private fun newDraweeControllerBuilder(
context: ThemedReactContext
): AbstractDraweeControllerBuilder<*, *, *, *> {
if (!FrescoModule.hasBeenInitialized()) {
// FrescoModule initializes Fresco on the native modules thread while the JS bundle loads, so
// the first Image can be created before that finishes. Getting the module waits for it.
// Fresco.hasBeenInitialized() doesn't help here: it turns true when initialization starts.
context.reactApplicationContext.getNativeModule(FrescoModule::class.java)

@Abbondanzo Abbondanzo Nov 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fresco initialization can be pretty costly, and the createViewInstance method is called on the main thread. Since the builder isn't called until the image mounts and has dimensions, could we instead make the constructor argument a Provider<T> for a drawee controller builder?

}
return Fresco.newDraweeControllerBuilder()
}

public override fun getName(): String = REACT_CLASS

@ReactProp(name = "accessible")
Expand Down
Loading