feat: emit structured detached launch acknowledgement - #1645
Merged
Merged
Conversation
The tmpfs overlay on $HOME hid the host GPG keyring inside the sandbox, so git commits with commit.gpgsign failed with "can't connect to the keyboxd". Bind ~/.gnupg rw, bind the gpg-agent socket dir (XDG_RUNTIME_DIR/gnupg), and propagate GPG_TTY so pinentry-tty works. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wave's detached run path only printed a human acknowledgement to stderr, so structured local clients could not obtain the canonical run ID without scraping terminal output or guessing from “latest.”
When
wave run --detach --output jsonsucceeds, it now writes one JSON acknowledgement containingrun_id,pipeline_name,status: "running", anddetached: true. Text output is unchanged and quiet output remains silent. The acknowledgement means the child process was released; durable state must still be observed withwave status.Validation:
go test ./...; focused command and runner tests;gofmt;git diff --check. An installed build launched an isolated mock pipeline with JSON-only stdout, retrieved it by the returned run ID, and accepted a structured cancellation request.This is the structured seam used by re-cinq/pi#19 so Pi can launch Wave locally without an API URL or WebUI server.