Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both existing workflows configure with
-DTHERMOGPU_ENABLE_CUDA=OFF, so the hosted runners never build or run the CUDA backend, includingpr_cuda_batchandpr_cuda_differential. This adds a separate, optional workflow.github/workflows/gpu-sim.ymlthat builds with CUDA on and runs ctest on a simulated NVIDIA H100 using PantheonSim (no GPU needed). I am the author of PantheonSim, so please weigh this accordingly.It does not touch
ci.ymlorcpu.ymland is not meant to be a required check. A simulator cannot reproduce hardware-specific behavior or timing, so it complements real-GPU testing and does not replace it.What it does:
-DTHERMOGPU_ENABLE_CUDA=ON -DCMAKE_CUDA_ARCHITECTURES=90-virtual -DCMAKE_CUDA_RUNTIME_LIBRARY=Shared(CMakeLists.txtsets no CUDA architecture; the simulator runs the embedded PTX and needs a shared CUDA runtime)ctestundervgpu runmainthat touchsrc/,include/,tests/,apps/,cmake/orCMakeLists.txt, with a concurrency group that cancels superseded runsNotes:
pr_cuda_batch,pr_cuda_differentialand the CUDA parity tests.thermomodel_pr_tp_cuda_parityis excluded (24 tests in total). Its tolerance is 1e-12, and the simulated H100 gives a scaled error of 1.04e-12 at 3 of 4,816,368 comparisons (T=1156, p=125.89, field 14). The same PTX built for 86-virtual gives at most 9.1e-13 on an RTX 3060. The kernel takes reciprocals fromrcp.approx.ftz.f64followed by Newton steps, and the low bits of that instruction are not specified, so I read this as a tight tolerance and not a bug in either side. The comment in the workflow says so. If you would rather keep the test, a slightly looser tolerance there would let it run.