You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
RDKEMW-28050 Mitigate Frontier AI Scan for system maintenance scripts - #643
Reason for change:
- Validate cron entries to reject dangerous shell characters (&, |, ;)
- Escape special characters in sed expressions for safe path/name matching
- Use literal grep search to prevent pattern interpretation
- Quote process names to prevent word splitting in grep commands
- Validate DCMSettings.conf is not a symlink and URL format is valid
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
The cron updater continues after lock-acquisition failure, allowing concurrent runs to overwrite shared state and install incomplete or stale crontabs.
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
Cron validation still allows pipes that can execute additional commands, while maintenance handling continues to read rejected symlinks and accepts malformed upload URLs.
Validate the complete HTTP(S) URL and require a host
lib/rdk/Start_MaintenanceTasks.sh:156
This validates only the scheme prefix: malformed values such as https:// pass and are forwarded to logupload as valid destinations. Validate a complete, single HTTP(S) URL with a nonempty host before assigning it, so malformed configuration takes the invalid-URL path instead of reaching the uploader.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: