Repository navigation
Conversation
Reason for change: With default KillMode=control-group, systemctl stop already SIGTERMs (then SIGKILLs after TimeoutStopSec) any process still in the cgroup — so no ExecStop is needed. $MAINPID is returned as 0, so it is empty Test Procedure: Check for service failure after stopping the service Priority: P1 Risks: None Signed-off-by: Faizal Hasan.Z <faizalhasan_zahirhussain@comcast.com
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The SIGTERM handler only releases the lock without exiting, so discovery can continue past TimeoutStopSec=3, forcing systemd to kill the process and mark the service failed.
1 open issue
What changed in this PR
This PR removes the explicit stop command from the device-details cache service, relying on systemd’s default process-group termination to avoid failures caused by an unavailable $MAINPID.
Changes:
- Removes
ExecStop=/bin/kill -9 $MAINPID. - Retains the three-second stop timeout.
| File | Description |
|---|---|
systemd_units/update-device-details.service |
Removes the explicit kill command and delegates termination to systemd. |
Review effort: Balanced
| SyslogIdentifier="getDeviceDetails" | ||
| ExecStart=/bin/sh -c '/lib/rdk/getDeviceDetails.sh "" "" "true" &' | ||
| ExecStop=/bin/kill -9 $MAINPID | ||
| TimeoutStopSec=3 |
…ck twice on SIGTERM' Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Reason for change: With default KillMode=control-group, systemctl stop already SIGTERMs (then SIGKILLs after TimeoutStopSec) any process still in the cgroup — so no ExecStop is needed. $MAINPID is returned as 0, so it is empty.
Test Procedure: Check for service failure after stopping the service
Priority: P1
Risks: None
Signed-off-by: Faizal Hasan.Z <faizalhasan_zahirhussain@comcast.com