Skip to content

Fix specification review findings - #37

Merged
rasuvaeff merged 1 commit into
masterfrom
fix/review-findings
Sep 13, 2026
Merged

rasuvaeff merged 1 commit into
masterfrom
fix/review-findings

Conversation

@rasuvaeff

Copy link
Copy Markdown
Owner

Summary

  • close security, composition, validation, and DateTime findings F-1 through F-7
  • update rasuvaeff/property-testing-testo from ^0.4 to ^0.10
  • strengthen property coverage for generated DateTime OR values and BETWEEN edge examples
  • correct comparative benchmark baselines and document the callback/modifier contracts

Fixes

  • allow-list direct OrConditionSpecification operators
  • preserve ORDER BY, LIMIT, and OFFSET across orWhere() and nested callback builders
  • require zero-based two-element lists for BETWEEN
  • normalize DateTime values through yiisoft/db DateTimeValue (including OR and is/is not)

Verification

  • composer build passed
  • composer release-check passed
  • composer test: 322 tests, 4168 assertions
  • composer bench: 2 benchmarks passed
  • both examples executed successfully
  • PHP lint passed for all examples and benchmarks
  • Psalm, CS fixer, Rector, require-checker, and BC check passed
  • mutation testing could not start because the composer:2 image has no pcov/phpdbg/xdebug coverage generator

@coderabbitai

coderabbitai Bot commented Sep 13, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 24de54d4-dd31-43a7-ac54-cca8ae164ac8


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rasuvaeff
rasuvaeff merged commit 6af904a into master Sep 13, 2026
10 checks passed
@rasuvaeff
rasuvaeff deleted the fix/review-findings branch September 19, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant