Skip to content

Ask the contract whether the number branch admits an integer; refuse multiples a double cannot spell (0.15.2) - #134

Merged
rasuvaeff merged 1 commit into
masterfrom
fix/132-133-decimal-multiples
Sep 19, 2026
Merged

rasuvaeff merged 1 commit into
masterfrom
fix/132-133-decimal-multiples

Conversation

@rasuvaeff

Copy link
Copy Markdown
Owner

Fixes #132
Fixes #133

composer build   PASS
composer rector  PASS
package-audit    0 errors, 0 warnings

…multiples a double cannot spell; rector on every PR

numberBranchAdmits() held a copy of the float multipleOf rule the contract
left in 0.12.1, and the two disagreed on 4670 of the integers in ±100000
for 0.7: the generator kept 58254 on the integer branch, the contract saw
it on both. SchemaCheck::isMultipleOf() is the verdict now (#132).

A number bound so wide that its decimal multiples need more significant
digits than a double holds fails closed at compile time; a multiple that
divides one is exempt (#133). static-analysis.yml runs rector on every
PR: 0.15.0 shipped with a rule red.
@coderabbitai

coderabbitai Bot commented Sep 19, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: d32081c8-cecf-4c92-8dd5-f36ce6407fe2


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rasuvaeff
rasuvaeff merged commit c0b0eb1 into master Sep 19, 2026
13 checks passed
@rasuvaeff
rasuvaeff deleted the fix/132-133-decimal-multiples branch September 19, 2026 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant