Emit the clean decimal multiple, always; require openapi-contract ^0.12.1 (0.15.1) - #131
Merged
Merged
Conversation
…12.1 The contract judges multipleOf on the decimals a message spells since 0.12.1 (openapi-contract#151): 64.1 is a multiple of 0.1 and 64.10000000000001 is not, on every machine. 0.15.0 emitted that float product wherever the contract's old float path demanded it, and 0.12.1 rejects it as the specification does. The zoo's precise.get carries a decimal multipleOf again; the tests that pinned the agreement no longer skip under ext-bcmath.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to openapi-contract#151 / its 0.12.1:
multipleOfis judged on the decimals a message spells, so a generated multiple is the clean decimal it means —64.1, never64.10000000000001. 0.15.0 emitted that float product wherever the contract's old float path demanded it (from about 64 upward formultipleOf: 0.1), and 0.12.1 rejects the product as the specification does.ScalarArbitraries::multipleOf()isround($k * $m, $decimals)again, with no validator-agreement branch.precise.getin the zoo carriesstep(multipleOf: 0.1) again; the contract's corpus was re-recorded from it in openapi-contract#153.WireAgreementTestno longer skips the multipleOf datasets underext-bcmath(the CI runners load it); a 100–200 window over0.7joins them.bin/record-openapi-corpus(monorepo) mounts the monorepo root so a path-repository contract records too.