Restore FileIO Excel support (including xls) and reclaim loader priority, migrate to test item framework

.github/dependabot.yml

@@ -0,0 +1,10 @@
+version: 2
+updates:
+  - package-ecosystem: "julia"
+    directory: "/"
+    schedule:
+      interval: "weekly"
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "weekly"

.github/workflows/juliaci.yml

@@ -0,0 +1,17 @@
+name: Julia CI
+
+on:
+  push: {branches: [main,master]}
+  pull_request: {types: [opened,synchronize,reopened,ready_for_review,converted_to_draft]}
+  issue_comment: {types: [created]}
+  workflow_dispatch: {inputs: {feature: {type: choice, description: What to run, options: [DocDeploy,LintAndTest,TagBot]}}}
+
+jobs:
+  julia-ci:
+    uses: julia-testitems/testitem-workflow/.github/workflows/juliaci.yml@v2
+    with:
+      include-all-compatible-minor-versions: true
+      include-rc-versions: true
+    permissions: write-all
+    secrets:
+      codecov_token: ${{ secrets.CODECOV_TOKEN }}

.gitignore

@@ -3,3 +3,6 @@
 *.jl.mem
 Manifest.toml
 .vscode
+docs/build/
+docs/Manifest.toml
+test-output*.*

LICENSE.md

@@ -1,6 +1,6 @@
 The ExcelFiles.jl package is licensed under the MIT "Expat" License:
 
-> Copyright (c) 2017-2019: David Anthoff.
+> Copyright (c) 2017-2026: David Anthoff.
 > 
 > 
 > Permission is hereby granted, free of charge, to any person obtaining a copy

Project.toml

@@ -1,4 +1,4 @@
 name = "ExcelFiles"
 uuid = "89b67f3b-d1aa-5f6f-9ca4-282e8d98620d"
 version = "1.0.1-DEV"
 
@@ -10,28 +10,29 @@
 IterableTables = "1c8ee90f-4401-5389-894e-7a04a3dc0f4d"
 IteratorInterfaceExtensions = "82899510-4779-5014-852e-03e436cf321d"
 Printf = "de0858da-6303-5e67-8744-51eddeeeb8d7"
-PyCall = "438e738f-606a-5dbb-bf0a-cddfbfd45ab0"
 TableShowUtils = "5e66a065-1f0a-5976-b372-e0b8c017ca10"
 TableTraits = "3783bdb8-4a98-5b6b-af9a-565f29a5fe9c"
 TableTraitsUtils = "382cd787-c1b6-5bf2-a167-d5b971a19bda"
 XLSX = "fdbf4ff8-1666-58a4-91e7-1b58723a45e0"
 
 [compat]
-DataValues = "0.4.11"
-ExcelReaders = "0.11"
+DataValues = "0.4.11, 0.5, 1"
+Dates = "1"
+ExcelReaders = "0.13, 1"
 FileIO = "1"
 IterableTables = "0.8.3, 0.9, 0.10, 0.11, 1"
 IteratorInterfaceExtensions = "0.1.1, 1"
-PyCall = "1.90"
-TableShowUtils = "0.2"
+Printf = "1"
+TableShowUtils = "0.2, 0.3, 1"
 TableTraits = "0.3.1, 0.4, 1"
 TableTraitsUtils = "0.3, 0.4, 1"
-XLSX = "0.4.1, 0.5, 0.6, 0.7, 0.8, 0.9"
+XLSX = "0.12"
 julia = "1"
 
 [extras]
 DataFrames = "a93c6f00-e57d-5684-b7b6-d8193f3e46c0"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
+TestItemRunner = "f8b46487-2199-4994-9208-9a1283c18c0a"
 
 [targets]
-test = ["Test", "DataFrames"]
+test = ["Test", "DataFrames", "TestItemRunner"]

README.md

@@ -1,14 +1,21 @@
 # ExcelFiles
 
 [![Project Status: Active - The project has reached a stable, usable state and is being actively developed.](http://www.repostatus.org/badges/latest/active.svg)](http://www.repostatus.org/#active)
-[![Build Status](https://travis-ci.org/queryverse/ExcelFiles.jl.svg?branch=master)](https://travis-ci.org/queryverse/ExcelFiles.jl)
-[![Build status](https://ci.appveyor.com/api/projects/status/wfx5avj0s2m0x94w/branch/master?svg=true)](https://ci.appveyor.com/project/queryverse/excelfiles-jl/branch/master)
+[![Build Status](https://github.com/queryverse/ExcelFiles.jl/actions/workflows/juliaci.yml/badge.svg?branch=main)](https://github.com/queryverse/ExcelFiles.jl/actions/workflows/juliaci.yml)
 [![codecov.io](http://codecov.io/github/queryverse/ExcelFiles.jl/coverage.svg?branch=master)](http://codecov.io/github/queryverse/ExcelFiles.jl?branch=master)
 
 ## Overview
 
 This package provides load support for Excel files under the
-[FileIO.jl](https://github.com/JuliaIO/FileIO.jl) package.
+[FileIO.jl](https://github.com/JuliaIO/FileIO.jl) package. Both modern xlsx
+files and legacy xls files can be loaded (the format is detected from the
+content of the file); saving is supported for xlsx files.
+
+Note that the central FileIO registry routes Excel files to
+[XLSX.jl](https://github.com/JuliaData/XLSX.jl) and does not cover xls files.
+Once ExcelFiles is loaded (``using ExcelFiles``), its loader takes priority,
+which restores range-based loading (``"Sheet1!A1:C4"``), the lazy iterable
+table interface, and support for xls files.
 
 ## Installation
 

docs/Project.toml

@@ -2,4 +2,4 @@
 Documenter = "e30172f5-a6a5-5a46-863b-614d45cd2de4"
 
 [compat]
-Documenter = "~0.24"
+Documenter = "1"

docs/make.jl

@@ -2,7 +2,8 @@ using Documenter, ExcelFiles
 
 makedocs(modules=[ExcelFiles],
 	sitename="ExcelFiles.jl",
-	analytics="UA-132838790-1",
+	format = Documenter.HTML(analytics = "UA-132838790-1"),
+	warnonly = [:missing_docs],
 	pages=[
         "Introduction" => "index.md"
     ])

src/ExcelFiles.jl

@@ -1,12 +1,36 @@
 module ExcelFiles
 
 
 using ExcelReaders, XLSX, IteratorInterfaceExtensions, TableTraits, DataValues
 using TableTraitsUtils, FileIO, TableShowUtils, Dates, Printf
 import IterableTables
 
 export load, save, File, @format_str
 
+function __init__()
+    # Since FileIO PR #439 (July 2026) the central FileIO registry routes
+    # format"Excel" to XLSX.jl's own FileIO extension, and no longer covers
+    # legacy xls files at all. Loading ExcelFiles puts its loader first
+    # again, and registers a format for xls files. Users who don't load
+    # ExcelFiles are unaffected.
+    try
+        loaders = get!(Vector{FileIO.ActionSource}, FileIO.sym2loader, :Excel)
+        filter!(x -> x !== ExcelFiles, loaders)
+        pushfirst!(loaders, ExcelFiles)
+        savers = get!(Vector{FileIO.ActionSource}, FileIO.sym2saver, :Excel)
+        filter!(x -> x !== ExcelFiles, savers)
+        pushfirst!(savers, ExcelFiles)
+
+        if !haskey(FileIO.sym2info, :ExcelLegacy)
+            FileIO.add_format(FileIO.format"ExcelLegacy", (), [".xls"],
+                [:ExcelFiles => Base.UUID("89b67f3b-d1aa-5f6f-9ca4-282e8d98620d"), FileIO.LOAD])
+        end
+    catch err
+        @warn "ExcelFiles could not register itself with FileIO. Loading Excel files via FileIO.load may not use ExcelFiles." exception = (err, catch_backtrace())
+    end
+    return nothing
+end
+
 struct ExcelFile
     filename::String
     range::String
@@ -21,15 +45,17 @@
     TableShowUtils.printHTMLtable(io, getiterator(source))
 end
 
 Base.Multimedia.showable(::MIME"text/html", source::ExcelFile) = true
 
 function Base.show(io::IO, ::MIME"application/vnd.dataresource+json", source::ExcelFile)
     TableShowUtils.printdataresource(io, getiterator(source))
 end
 
 Base.Multimedia.showable(::MIME"application/vnd.dataresource+json", source::ExcelFile) = true
 
-function fileio_load(f::FileIO.File{FileIO.format"Excel"}, range; keywords...)
+const ExcelFileFormat = Union{FileIO.File{FileIO.format"Excel"},FileIO.File{FileIO.format"ExcelLegacy"}}
+
+function fileio_load(f::ExcelFileFormat, range; keywords...)
     return ExcelFile(f.filename, range, keywords)
 end
 
@@ -38,8 +64,12 @@
     return XLSX.writetable(f.filename, cols, colnames; sheetname=sheetname)
 end
 
+function fileio_save(f::FileIO.File{FileIO.format"ExcelLegacy"}, data; kwargs...)
+    error("Writing legacy xls files is not supported. Save to an xlsx file instead.")
+end
+
 IteratorInterfaceExtensions.isiterable(x::ExcelFile) = true
 TableTraits.isiterabletable(x::ExcelFile) = true
 
 function gennames(n::Integer)
     res = Vector{Symbol}(undef, n)
@@ -52,7 +82,7 @@
 function _readxl(file::ExcelReaders.ExcelFile, sheetname::AbstractString, startrow::Integer, startcol::Integer, endrow::Integer, endcol::Integer; header::Bool=true, colnames::Vector{Symbol}=Symbol[])
     data = ExcelReaders.readxl_internal(file, sheetname, startrow, startcol, endrow, endcol)
 
     nrow, ncol = size(data)
 
     if length(colnames) == 0
         if header
@@ -112,7 +142,7 @@
         _readxl(excelfile, sheetname, startrow, startcol, endrow, endcol; file.keywords...)
     else
         excelfile = openxl(file.filename)
-        sheet = excelfile.workbook.sheet_by_name(file.range)
+        sheet = ExcelReaders.sheet_handle(excelfile, file.range)
 
         keywords = filter(i -> !(i[1] in (:header, :colnames)), file.keywords)
         startrow, startcol, endrow, endcol = ExcelReaders.convert_args_to_row_col(sheet; keywords...)