Skip to content

arm64: dts: qcom: sm8750: Add Pakala (Adreno 830) GPU DT nodes - #1702

Closed
quic-ksanadhy wants to merge 0 commit into
qualcomm-linux:tech/all/dt/pakalafrom
quic-ksanadhy:tech/all/dt/pakala
Closed

arm64: dts: qcom: sm8750: Add Pakala (Adreno 830) GPU DT nodes#1702
quic-ksanadhy wants to merge 0 commit into
qualcomm-linux:tech/all/dt/pakalafrom
quic-ksanadhy:tech/all/dt/pakala

Conversation

@quic-ksanadhy

@quic-ksanadhy quic-ksanadhy commented Aug 17, 2026

Copy link
Copy Markdown

Add Device Tree support for the Adreno 830 GPU on the Pakala (SM8750) SoC.

  • FROMLIST: arm64: dts: qcom: sm8750: Add GPU clock & IOMMU nodes
  • FROMLIST: arm64: dts: qcom: sm8750: Add GPU and GMU nodes
  • FROMLIST: arm64: dts: qcom: sm8750: Add GPU cooling
  • FROMLIST: arm64: dts: qcom: sm8750-mtp: Enable Adreno 830 GPU
  • FROMLIST: arm64: dts: qcom: sm8750-qrd: Enable Adreno 830 GPU

CRs-Fixed: 4647429

@qcomlnxci
qcomlnxci requested review from a team, Amit Kucheria (idlethread), knaveen-qc and Trilok Soni (trsoni) and removed request for a team August 17, 2026 11:30
@qlijarvis

Copy link
Copy Markdown

PR #1702 — validate-patch

PR: #1702

Verdict Issues Detailed Report
6 Full report

Final Summary

  1. Lore link present: No - all 5 commits with FROMLIST: prefix lack required Link: tags
  2. Lore link matches PR commits: N/A - no lore links to compare against
  3. Upstream patch status: N/A - cannot check upstream status without lore links
  4. PR present in qcom-next/topics: Fail - 1/5 commit(s) are missing from both qcom-next and topics
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #1702 - FROMLIST: arm64: dts: qcom: sm8750: Add GPU clock & IOMMU nodes (5 commits)
Upstream commit: N/A (no lore.kernel.org links found)
Verdict: ❌ FAIL

Commit Message

Check Status Note
Subject matches upstream Cannot verify - no lore link provided
Body preserves rationale Cannot verify - no lore link provided
Fixes tag present/correct N/A No Fixes tags expected for new hardware enablement
Authorship preserved Cannot verify - no lore link to compare against
Backport note (if applicable) N/A Not a backport (FROMLIST prefix)

Diff

File Status Notes
arch/arm64/boot/dts/qcom/sm8750.dtsi Cannot verify against upstream - no lore link
arch/arm64/boot/dts/qcom/sm8750-mtp.dts Cannot verify against upstream - no lore link
arch/arm64/boot/dts/qcom/sm8750-qrd.dts Cannot verify against upstream - no lore link

Issues

Critical: Missing lore.kernel.org links

All 5 commits use the FROMLIST: prefix but lack the required Link: tag pointing to the lore.kernel.org posting. Per the validate-patch skill requirements and kernel submission guidelines:

  • Commit 1/5: FROMLIST: arm64: dts: qcom: sm8750: Add GPU clock & IOMMU - no Link tag
  • Commit 2/5: FROMLIST: arm64: dts: qcom: sm8750: Add GPU and GMU nodes - no Link tag
  • Commit 3/5: FROMLIST: arm64: dts: qcom: sm8750: Add GPU cooling - no Link tag
  • Commit 4/5: FROMLIST: arm64: dts: qcom: sm8750-mtp: Enable Adreno 830 - no Link tag
  • Commit 5/5: FROMLIST: arm64: dts: qcom: sm8750-qrd: Enable Adreno 830 - no Link tag

The FROMLIST: prefix explicitly indicates these patches were posted to a mailing list but not yet merged upstream. Each commit must include a Link: https://lore.kernel.org/r/<message-id> tag to reference the upstream posting.

Authorship concerns:

  • Commit 1/5: Uses Co-developed-by: Taniya Das - this may be correct if Taniya genuinely co-authored the patch, but without the lore link we cannot verify if this matches the upstream posting or if the primary author should be in From: instead.

Verdict

Do not merge. All 5 commits must be amended to add the required Link: tags before this PR can be validated.

Recommended Actions

  1. Locate the upstream lore postings for each commit (search lore.kernel.org by subject line)
  2. Add Link tags to each commit message:
    Link: https://lore.kernel.org/r/<message-id>
    
  3. Verify authorship matches the lore posting (especially commit 1/5 with Co-developed-by)
  4. Re-run validation after amendments

Example amendment command:

git rebase -i HEAD~5
# Mark each commit for 'reword'
# Add the Link: tag before the Signed-off-by: lines

Final Summary

  1. Lore link present: No - all 5 commits with FROMLIST: prefix lack required Link: tags
  2. Lore link matches PR commits: N/A - no lore links to compare against
  3. Upstream patch status: N/A - cannot check upstream status without lore links
  4. PR present in qcom-next/topics: Fail - per integration_presence_report.md: 1/5 commits missing from both qcom-next and topics; 4/5 commits show only partial presence (subject or partial tree evidence found, but full change not verified)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 21f58ca3b79427e34eafb4c18ff916d8bb95f7ea
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/5 [PATCH 1/5] FROMLIST: arm64: dts: qcom: sm8750: Add GPU clock & IOMMU partial - subject or partial tree evidence found, but full change was not verified missing - no subject, patch-id, or full tree-content match found partial
2/5 [PATCH 2/5] FROMLIST: arm64: dts: qcom: sm8750: Add GPU and GMU nodes partial - subject or partial tree evidence found, but full change was not verified missing - no subject, patch-id, or full tree-content match found partial
3/5 [PATCH 3/5] FROMLIST: arm64: dts: qcom: sm8750: Add GPU cooling missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
4/5 [PATCH 4/5] FROMLIST: arm64: dts: qcom: sm8750-mtp: Enable Adreno 830 partial - subject or partial tree evidence found, but full change was not verified missing - no subject, patch-id, or full tree-content match found partial
5/5 [PATCH 5/5] FROMLIST: arm64: dts: qcom: sm8750-qrd: Enable Adreno 830 partial - subject or partial tree evidence found, but full change was not verified missing - no subject, patch-id, or full tree-content match found partial

Final Status

overall_status: FAIL
present_commits: 0/5
partial_commits: 4/5
missing_commits: 1/5
topics_checked_for_commits: 5/5
final_summary: PR present in qcom-next/topics: Fail - 1/5 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1702 — checker-log-analyzer

PR: #1702
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/32025207175

Checker Result Summary
Checker Result Summary
checkpatch All 5 commits passed with no style issues
dt-binding-check ⏭️ Skipped - no binding changes
dtb-check Passed - no new DTB validation errors
sparse-check ⏭️ Skipped - no C/H file changes
check-uapi-headers ⏭️ Skipped - no UAPI changes
check-patch-compliance 5 commits missing Link: tags
tag-check All commits have valid FROMLIST: prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1702 - Add GPU support for SM8750 (Adreno 830)
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/32025207175

Checker Result Summary
checkpatch All 5 commits passed with no style issues
dt-binding-check ⏭️ Skipped - no binding changes
dtb-check Passed - no new DTB validation errors
sparse-check ⏭️ Skipped - no C/H file changes
check-uapi-headers ⏭️ Skipped - no UAPI changes
check-patch-compliance 5 commits missing Link: tags
tag-check All commits have valid FROMLIST: prefix

❌ check-patch-compliance

Root cause: All 5 commits are tagged with FROMLIST: but are missing the required Link: trailer pointing to the upstream lore.kernel.org posting.

Failure details:

Checking commit: FROMLIST: arm64: dts: qcom: sm8750: Add GPU clock & IOMMU nodes
No 'Link' found in commit message

Checking commit: FROMLIST: arm64: dts: qcom: sm8750: Add GPU and GMU nodes
No 'Link' found in commit message

Checking commit: FROMLIST: arm64: dts: qcom: sm8750: Add GPU cooling
No 'Link' found in commit message

Checking commit: FROMLIST: arm64: dts: qcom: sm8750-mtp: Enable Adreno 830 GPU
No 'Link' found in commit message

Checking commit: FROMLIST: arm64: dts: qcom: sm8750-qrd: Enable Adreno 830 GPU
No 'Link' found in commit message

Fix: Add a Link: trailer to each commit message pointing to the lore.kernel.org URL where the patch was posted upstream.

For each commit:

git rebase -i <base_sha>   # mark each commit as 'edit'
git commit --amend         # add Link: https://lore.kernel.org/... to the commit body
git rebase --continue

The Link: tag should be placed in the commit message body (after the description, before or after Signed-off-by: trailers), in the format:

Link: https://lore.kernel.org/r/<message-id>

Reproduce locally:

cd /path/to/kernel
bash ../kernel-checkers/check-patch-compliance.sh \
  --kernel-src . \
  --base 21f58ca3b79427e34eafb4c18ff916d8bb95f7ea \
  --head <your-pr-head-sha>

Verdict

5 blockers to fix before merge — all commits require Link: tags pointing to their upstream lore.kernel.org postings. Once the Link: trailers are added, all checkers should pass.

@qcomlnxci
qcomlnxci requested a review from a team August 18, 2026 04:24
@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1702

PR: #1702
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/32099023816

# Error File:Line PR-introduced? Root Cause
N/A Merge conflicts (1003 files) Multiple files No PR #1702 appears to be empty (0 bytes patch), but the CI workflow attempts to merge it on top of an integration branch that already includes topic/tech/all/dt/pakala. The merge operation fails with 1003 conflicts across the entire kernel tree, indicating the PR branch has diverged significantly from the integration baseline.

Verdict

This is not a compilation failure. The build failed during the merge phase before any compilation could occur. The PR itself contains no changes (empty patch), but the merge conflicts suggest the PR branch is based on an incompatible baseline compared to the integration branch (tag 21f58ca3b79427e34eafb4c18ff916d8bb95f7ea + topic/tech/all/dt/pakala).

📎 Detailed analysis: build_job_detailed.md

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1702

PR: #1702
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/32099023816

# Error File:Line PR-introduced? Root Cause
N/A Merge conflicts (1003 files) Multiple files No Integration merge failure - not a compilation error

Verdict

This is not a compilation failure. The build failed during the git merge phase when attempting to integrate PR #1702 (branch tech/all/dt/pakala) into the integration branch based on commit 21f58ca3b79427e34eafb4c18ff916d8bb95f7ea. The failure occurred before any compilation was attempted, with 1003 merge conflicts across the codebase. The PR patch file is empty, indicating this may be a merge/integration PR rather than a code change PR.

📎 Detailed analysis: Full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants