Skip to content

drm/msm: Add Pakala (Adreno 830) GPU support - #1701

Open
quic-ksanadhy wants to merge 2 commits into
qualcomm-linux:tech/mm/gpufrom
quic-ksanadhy:tech/mm/gpu
Open

drm/msm: Add Pakala (Adreno 830) GPU support#1701
quic-ksanadhy wants to merge 2 commits into
qualcomm-linux:tech/mm/gpufrom
quic-ksanadhy:tech/mm/gpu

Conversation

@quic-ksanadhy

@quic-ksanadhy quic-ksanadhy commented Aug 17, 2026

Copy link
Copy Markdown

Add support for the Pakala SoC's Adreno 830 GPU.

  • FROMLIST: drm/msm/a8xx: Add support for Adreno 830 GPU
  • FROMLIST: dt-bindings: display/msm: Document Adreno 830 GPU/GMU

CRs-Fixed: 4647428

@qcomlnxci
qcomlnxci requested review from a team and Rajesh Kemisetti (quic-rajeshk) and removed request for a team August 17, 2026 11:17
@qlijarvis

Copy link
Copy Markdown

PR #1701 — validate-patch

PR: #1701

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: No — both commits use FROMLIST: prefix but lack required Link: tags
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: Unknown — cannot verify without lore links
  4. PR present in qcom-next/topics: Partial - 2/2 commit(s) only have partial integration evidence
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #1701 - Add support for Adreno 830 GPU
Upstream commit: N/A (no lore links found)
Verdict: ❌ FAIL

Commit Message

Commit 1/2: FROMLIST: drm/msm/a8xx: Add support for Adreno 830 GPU

Check Status Note
Subject matches upstream ⏭️ N/A No lore link to compare against
Body preserves rationale ⏭️ N/A No lore link to compare against
Fixes tag present/correct ⏭️ N/A Not applicable (new feature)
Authorship preserved ⏭️ N/A No lore link to compare against
Backport note (if applicable) ⏭️ N/A Not a backport

Commit 2/2: FROMLIST: dt-bindings: display/msm: Document Adreno 830 GPU/GMU

Check Status Note
Subject matches upstream ⏭️ N/A No lore link to compare against
Body preserves rationale ⏭️ N/A No lore link to compare against
Fixes tag present/correct ⏭️ N/A Not applicable (new feature)
Authorship preserved ⏭️ N/A No lore link to compare against
Backport note (if applicable) ⏭️ N/A Not a backport

Diff

Cannot validate diff content without upstream lore source.

Issues

  1. Missing lore.kernel.org links (CRITICAL): Both commits use the FROMLIST: prefix, which according to the kernel commit prefix conventions means "Posted to mailing list, not yet merged" and requires a lore.kernel.org link. Neither commit includes a Link: tag pointing to the upstream posting.

  2. Incomplete integration presence: According to integration_presence_report.md, both commits show only partial presence in qcom-next and topics branches. This means subject or partial tree evidence was found, but the full change was not verified. Expected: commits should be fully present in integration branches before merging to topics.

Verdict

Do not merge. Both commits must include Link: https://lore.kernel.org/r/<message-id> tags pointing to their upstream mailing list postings. The FROMLIST: prefix explicitly indicates these patches were posted to a mailing list and requires attribution to the upstream source.

Final Summary

  1. Lore link present: No — both commits use FROMLIST: prefix but lack required Link: tags
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: Unknown — cannot verify without lore links
  4. PR present in qcom-next/topics: Partial — 2/2 commits show only partial integration evidence (subject or partial tree match found, but full change not verified)

Recommendation

Add Link: https://lore.kernel.org/r/<message-id> lines to both commit messages pointing to the original mailing list postings, then re-run validation. The FROMLIST: prefix is specifically for patches posted to upstream mailing lists and requires proper attribution.

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 21f58ca3b79427e34eafb4c18ff916d8bb95f7ea
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/2 [PATCH 1/2] FROMLIST: drm/msm/a8xx: Add support for Adreno 830 GPU partial - subject or partial tree evidence found, but full change was not verified missing - no subject, patch-id, or full tree-content match found partial
2/2 [PATCH 2/2] FROMLIST: dt-bindings: display/msm: Document Adreno 830 partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial

Final Status

overall_status: PARTIAL
present_commits: 0/2
partial_commits: 2/2
missing_commits: 0/2
topics_checked_for_commits: 2/2
final_summary: PR present in qcom-next/topics: Partial - 2/2 commit(s) only have partial integration evidence

@qlijarvis

Copy link
Copy Markdown

PR #1701 — checker-log-analyzer

PR: #1701
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/32024197573

Checker Result Summary
Checker Result Summary
checkpatch 1 CHECK: line ending with '('
dt-binding-check KeyError in schema processing (pre-existing tree issue)
dtb-check ⏭️ No DTS changes
sparse-check Passed
check-uapi-headers Passed
check-patch-compliance Missing Link: tags in both commits
tag-check Both commits have FROMLIST: prefix
qcom-next-check ⚠️ FROMLIST: commits only partially present in qcom-next

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1701 - Add support for Adreno 830 GPU
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/32024197573

Checker Result Summary
checkpatch 1 CHECK: line ending with '('
dt-binding-check KeyError in schema processing (pre-existing tree issue)
dtb-check ⏭️ No DTS changes
sparse-check Passed
check-uapi-headers Passed
check-patch-compliance Missing Link: tags in both commits
tag-check Both commits have FROMLIST: prefix
qcom-next-check ⚠️ FROMLIST: commits only partially present in qcom-next

❌ checkpatch

Root cause: Code style issue - line ending with opening parenthesis

Failure details:

Commit c5d7f6392f78 ("FROMLIST: drm/msm/a8xx: Add support for Adreno 830 GPU")
CHECK: Lines should not end with a '('
#358: FILE: drivers/gpu/drm/msm/adreno/a6xx_catalog.c:2726:
+		.speedbins = ADRENO_SPEEDBINS(

c5d7f6392f78 total: 0 errors, 0 warnings, 1 checks, 370 lines checked

Fix: Move the opening parenthesis to the next line or keep the first argument on the same line:

// Option 1: Move content to same line
.speedbins = ADRENO_SPEEDBINS(0, 1, 2),

// Option 2: If multi-line is needed, keep '(' with content
.speedbins = ADRENO_SPEEDBINS(
		0, 1, 2
),

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git eaa684b68ce5..f1c3bdcb6a80

❌ dt-binding-check

Root cause: Pre-existing tree issue - KeyError in dtschema validator for ti,pruss-intc.yaml schema

Failure details:

KeyError: 'http://devicetree.org/schemas/interrupt-controller/ti,pruss-intc.yaml#'
make[3]: *** [Documentation/devicetree/bindings/Makefile:75: 
    Documentation/devicetree/bindings/processed-schema.json] Error 1

However, the log shows:

dt_binding_check passed for Documentation/devicetree/bindings/display/msm/gmu.yaml...
dtbs_check passed for Documentation/devicetree/bindings/display/msm/gmu.yaml...
dt_binding_check passed for Documentation/devicetree/bindings/display/msm/gpu.yaml...
dtbs_check passed for Documentation/devicetree/bindings/display/msm/gpu.yaml...

Fix: This is a pre-existing tree issue unrelated to this PR. The PR's binding changes (gmu.yaml and gpu.yaml) passed validation successfully. The KeyError occurs during the global schema processing phase and is caused by an issue in the ti,pruss-intc.yaml binding in the tree.

Action: This failure should not block the PR. The PR's binding changes are valid. The tree-wide schema issue needs to be fixed separately.

Reproduce locally:

make -j$(nproc) O=out defconfig
make -j$(nproc) O=out dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/msm/

❌ check-patch-compliance

Root cause: Both commits are missing Link: tags pointing to the upstream lore.kernel.org posting

Failure details:

Checking commit: FROMLIST: drm/msm/a8xx: Add support for Adreno 830 GPU
No 'Link' found in commit message

Checking commit: FROMLIST: dt-bindings: display/msm: Document Adreno 830 GPU/GMU
No 'Link' found in commit message

Fix: Add Link: tags to both commit messages pointing to the lore.kernel.org URLs where these patches were posted upstream.

For commit 1 (c5d7f63):

git rebase -i <base_sha>   # mark commit as 'edit'
git commit --amend
# Add to commit body before Signed-off-by:
Link: https://lore.kernel.org/.../<message-id>
git rebase --continue

For commit 2 (a23d76f):

# Same process - add Link: tag

The Link: tag should be placed in the commit body after the description and before the Signed-off-by: trailers.

Reproduce locally:

cd /path/to/kernel
bash ../kernel-checkers/check-patch-compliance.sh \
  --kernel-src . \
  --base <base_sha> \
  --head <head_sha>

⚠️ qcom-next-check

Status: Both commits have FROMLIST: prefix but are only partially present in qcom-next

Details:
From the integration presence report:

  • Commit 1/2: partial - subject or partial tree evidence found, but full change was not verified
  • Commit 2/2: partial - subject or partial tree evidence found in both qcom-next and topics

Implication: These patches may have been posted upstream (FROMLIST:) and partially integrated into qcom-next, but the full changes don't match exactly. This could indicate:

  1. The patches were modified after posting
  2. Only part of the series was integrated
  3. The patches are still under review upstream

Recommendation: Verify that:

  1. The Link: tags point to the correct upstream posting
  2. The patch content matches what was posted (or document any intentional differences)
  3. The upstream review status is tracked

Verdict

3 blockers to fix before merge:

  1. checkpatch - Fix the line-ending-with-'(' style issue in a6xx_catalog.c:2726
  2. check-patch-compliance - Add Link: tags to both commits pointing to lore.kernel.org
  3. dt-binding-check - This is a pre-existing tree issue and should NOT block this PR

Non-blocking observations:

  • The PR's binding changes (gmu.yaml, gpu.yaml) validated successfully
  • Both commits correctly use FROMLIST: prefix
  • Sparse, UAPI, and DTB checks passed cleanly

Recommended action: Fix items #1 and #2, then re-run CI. The dt-binding-check failure is a tree-wide issue that needs separate investigation.

Jie Zhang added 2 commits August 19, 2026 19:01
Add support for the Adreno 830 GPU present in SM8750 SoC. Adreno 830 GPU
belongs to the A8x Gen 1 family and it is architecturally close Adreno 840.
Add a new catalog entry along with the register list to enable support
for this GPU.

Signed-off-by: Jie Zhang <jie.zhang@oss.qualcomm.com>
Signed-off-by: Akhil P Oommen <akhilpo@oss.qualcomm.com>
Signed-off-by: Kaushal Sanadhya <ksanadhy@qti.qualcomm.com>
Link: https://lore.kernel.org/lkml/20260809-pakala-gpu-v1-1-207ad1fac1c7@oss.qualcomm.com/
Adreno 830 GPU present in SM8750 chipset belongs to the A8x family of
Adreno GPU. It is similar to Adreno 840 GPU with some meaningful
differences like GMEM , register file size etc.

Document Adreno 830 GPU and GMU present in the SM8750 chipset.

Signed-off-by: Jie Zhang <jie.zhang@oss.qualcomm.com>
Signed-off-by: Akhil P Oommen <akhilpo@oss.qualcomm.com>
Signed-off-by: Kaushal Sanadhya <ksanadhy@qti.qualcomm.com>
Link: https://lore.kernel.org/lkml/20260809-pakala-gpu-v1-2-207ad1fac1c7@oss.qualcomm.com/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants