Skip to content

PENDING: arm64: media: dts: sm8750-mtp: Add s5kjn5 image sensor on CSIPHY2 - #1673

Open
HangxiangMa wants to merge 15 commits into
qualcomm-linux:tech/all/dt/pakalafrom
HangxiangMa:dev/sm8750-s5kjn5
Open

PENDING: arm64: media: dts: sm8750-mtp: Add s5kjn5 image sensor on CSIPHY2#1673
HangxiangMa wants to merge 15 commits into
qualcomm-linux:tech/all/dt/pakalafrom
HangxiangMa:dev/sm8750-s5kjn5

Conversation

@HangxiangMa

Copy link
Copy Markdown
Contributor

Enable the camera subsystem on the SM8750 MTP along with the S5KJN5 sensor connected to CSIPHY2 through I2C9 on QUPv3_2. Add the sensor reset pin state on the TLMM GPIO and wire up the sensor supplies.

CRs-Fixed: 4640742

ALOK TIWARI (aloktiwa) and others added 15 commits July 2, 2026 16:09
amd_ntb_link_disable() prints "Enabling Link" which is misleading.
Update the message to reflect that the link is being disabled.

Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
…hare BAR

When BAR_PEER_SPAD and BAR_CONFIG share one PCI BAR, the module teardown
path ends up calling pci_iounmap() on the same iomem with some offset,
which is unnecessary and triggers a kernel warning like the following:

  Trying to vunmap() nonexistent vm area (0000000069a5ffe8)
  WARNING: mm/vmalloc.c:3470 at vunmap+0x58/0x68, CPU#5: modprobe/2937
  [...]
  Call trace:
   vunmap+0x58/0x68 (P)
   iounmap+0x34/0x48
   pci_iounmap+0x2c/0x40
   ntb_epf_pci_remove+0x44/0x80 [ntb_hw_epf]
   pci_device_remove+0x48/0xf8
   device_remove+0x50/0x88
   device_release_driver_internal+0x1c8/0x228
   driver_detach+0x50/0xb0
   bus_remove_driver+0x74/0x100
   driver_unregister+0x34/0x68
   pci_unregister_driver+0x34/0xa0
   ntb_epf_pci_driver_exit+0x14/0xfe0 [ntb_hw_epf]
  [...]

Fix it by unmapping only when PEER_SPAD and CONFIG use difference bars.

Cc: stable@vger.kernel.org
Fixes: e75d5ae ("NTB: epf: Allow more flexibility in the memory BAR map method")
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Signed-off-by: Koichiro Den <den@valinux.co.jp>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
Correct a function name and function parameter name to avoid
kernel-doc warnings:

Warning: include/linux/ntb.h:575 expecting prototype for
 ntb_default_port_count(). Prototype was for ntb_default_peer_port_count()
 instead
Warning: include/linux/ntb.h:590 function parameter 'pidx' not
 described in 'ntb_default_peer_port_number'

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Dave Jiang <dave.jiang@intel.com>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
The current list initialisation depends on the well hidden two zeros in
the PCI_VDEVICE macro. Instead use a named initialisation that is more
robust and easier to understand.

Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
Embedded Trace Router(ETR) is working as a DDR memory sink to collect
tracing data from source device and the CTCU device serves as the
control unit for the ETR device.

Link: https://lore.kernel.org/all/20260204-enable-ctcu-and-etr-v3-3-0bb95c590ae1@oss.qualcomm.com/
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Jie Gan <jie.gan@oss.qualcomm.com>
…nel nt37801

The NT37801 Sepc V1.0 chapter "5.7.1 Power On Sequence" states
VDDI=1.65V~1.95V, so set sufficient voltage for panel nt37801.

Signed-off-by: Ayushi Makhija <quic_amakhija@quicinc.com>
Link: https://lore.kernel.org/all/20260323102229.1546504-1-quic_amakhija@quicinc.com/

Signed-off-by: Arpit Saini <arpisain@qti.qualcomm.com>
The Inline Crypto Engine (ICE) exists as a standalone DT node, but the
UFS node lacks the required qcom,ice phandle reference.

Add the qcom,ice property to explicitly associate the UFS controller
with its ICE instance.

Fixes: d288abc ("arm64: dts: qcom: sm8750: Add UFS nodes for SM8750 SoC")
Signed-off-by: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Link: https://lore.kernel.org/lkml/20260429-sm8750_ice_dt_fix-v1-1-2540dc337082@oss.qualcomm.com/
Signed-off-by: Kumar Kartik <kkartik@qti.qualcomm.com>
Add PSCI SYSTEM_RESET2 reboot-modes for sm8750-mtp and sm8750-qrd for
use by the psci-reboot-mode driver.

The following modes are defined:
- bootloader: reboot into fastboot mode for fastboot flashing.
- edl: reboot into emergency download mode for image loading via
  the Firehose protocol.

Link: https://lore.kernel.org/r/20260529-psci_sys_reset-dt-changes-for-pakala-v2-1-1964ebf1924c@oss.qualcomm.com
Signed-off-by: Anurag Pateriya <anurag.pateriya@oss.qualcomm.com>
Add node for the SM8750 camera subsystem.

Signed-off-by: Hangxiang Ma <hangxiang.ma@oss.qualcomm.com>
Link: https://lore.kernel.org/all/20260618-pakala-camera-v2-1-9fbb729fd242@oss.qualcomm.com/
Qualcomm SM8750 SoC has three Camera Control Interface (CCI). Each
controller contains two I2C hosts.

Signed-off-by: Hangxiang Ma <hangxiang.ma@oss.qualcomm.com>
Link: https://lore.kernel.org/all/20260618-pakala-camera-v2-2-9fbb729fd242@oss.qualcomm.com/
Define pinctrl definitions to enable camera master clocks on SM8750.

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Hangxiang Ma <hangxiang.ma@oss.qualcomm.com>
Link: https://lore.kernel.org/all/20260618-pakala-camera-v2-3-9fbb729fd242@oss.qualcomm.com/
The traceNoC node used the "qcom,coresight-tnoc", "arm,primecell"
compatible, which places the device on the AMBA bus. To bind an AMBA
device, the bus reads the peripheral and component ID registers (PID/CID)
at the top of the device's register block and matches them against the
primecell ID. The traceNoC exposes the CID registers, but the Component ID
value returned by the hardware is 0x00000000 instead of a valid AMBA
Component ID, so the match never succeeds, the AMBA probe fails, and the
device is left stuck in deferred probe indefinitely.

Drop the "arm,primecell" entry and use the standalone "qcom,coresight-tnoc"
compatible, which binds via the platform driver by compatible string and
does not rely on the component ID register at all. This lets the device
probe on hardware that does not return a valid CID, while remaining an
Aggregator TNOC that retains ATID functionality.

Link: https://lore.kernel.org/all/20260710-fix-tracenoc-probe-issue-v6-4-41eb36fef8d9@oss.qualcomm.com/
Fixes: ebd1eb3 ("arm64: qcom: dts: sm8750: add coresight nodes")
Signed-off-by: Jie Gan <jie.gan@oss.qualcomm.com>
Add Battery Current Limiting (BCL) hardware monitor node for pmih0108
PMIC. The BCL monitors battery voltage and current, providing hardware
interrupts when configurable thresholds are violated.

Signed-off-by: Manaf Meethalavalappu Pallikunhi <manaf.pallikunhi@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260722-qcom-bcl-hwmon-v2-9-febe2805e17b@oss.qualcomm.com
…IPHY2

Enable the camera subsystem on the SM8750 MTP along with the S5KJN5
sensor connected to CSIPHY2 through I2C9 on QUPv3_2. Add the sensor
reset pin state on the TLMM GPIO and wire up the sensor supplies.

Signed-off-by: Hangxiang Ma <hangxiang.ma@oss.qualcomm.com>
@qlijarvis

Copy link
Copy Markdown

PR #1673 — validate-patch

PR: #1673

Verdict Issues Detailed Report
⚠️ 1 Full report

Final Summary

  1. Lore link present: No — PENDING: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — PENDING: work-in-progress, not posted upstream
  4. PR present in qcom-next/topics: Partial - 1/1 commit(s) only have partial integration evidence
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1673 - PENDING: arm64: media: dts: sm8750-mtp: Add s5kjn5 image sensor on CSIPHY2
Upstream commit: N/A (PENDING: prefix indicates work-in-progress)
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note
Subject matches upstream N/A PENDING: prefix - no upstream source to compare
Body preserves rationale Clear description of camera subsystem enablement
Fixes tag present/correct N/A Not a fix commit
Authorship preserved Author and Signed-off-by match
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/sm8750-mtp.dts Adds camera sensor configuration, GPIO pinctrl, I2C device, and CAMSS port

Issues

  • Integration presence: Integration report shows "partial" status - subject or partial tree evidence found in qcom-next, but full change was not verified. This suggests the commit may exist in a different form or be incomplete in the integration branch.

Verdict

This is a PENDING commit (work-in-progress) with no upstream lore link, which is expected and correct for this prefix. However, the partial integration presence status indicates the change may not be fully integrated into qcom-next yet. Verify the integration status before merging.

Final Summary

  1. Lore link present: No — PENDING: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — PENDING: work-in-progress, not posted upstream
  4. PR present in qcom-next/topics: Partial — 1/1 commit(s) only have partial integration evidence (subject or partial tree match found, but full change not verified in qcom-next)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 8d5dbc1b17adf8fe86a41adcda686785e73f5414
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] PENDING: arm64: media: dts: sm8750-mtp: Add s5kjn5 image partial - subject or partial tree evidence found, but full change was not verified missing - no subject, patch-id, or full tree-content match found partial

Final Status

overall_status: PARTIAL
present_commits: 0/1
partial_commits: 1/1
missing_commits: 0/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Partial - 1/1 commit(s) only have partial integration evidence

@qlijarvis

Copy link
Copy Markdown

PR #1673 — checker-log-analyzer

PR: #1673
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/31501828809

Checker Result Summary
Checker Result Summary
checkpatch 1 warning: undocumented DT compatible string
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check Passed
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance PENDING: prefix not accepted
tag-check Subject has valid prefix (PENDING:)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1673 - PENDING: arm64: media: dts: sm8750-mtp: Add s5kjn5 image sensor on CSIPHY2
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/31501828809
Target branch: tech/all/dt/pakala (qualcomm-linux/kernel-topics)

Checker Result Summary
checkpatch 1 warning: undocumented DT compatible string
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check Passed
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance PENDING: prefix not accepted
tag-check Subject has valid prefix (PENDING:)

❌ checkpatch

Root cause: The DT compatible string "samsung,s5kjn5" is not documented in Documentation/devicetree/bindings/vendor-prefixes.yaml or lacks a binding YAML file.

Failure details:

WARNING: DT compatible string "samsung,s5kjn5" appears un-documented -- check ./Documentation/devicetree/bindings/
#51: FILE: arch/arm64/boot/dts/qcom/sm8750-mtp.dts:1315:
+		compatible = "samsung,s5kjn5";

57854f43bb896b6415c42afe4ec5c4040e5e58a2 total: 0 errors, 1 warnings, 0 checks, 76 lines checked

Fix:

Option 1 (if binding exists upstream):

  • Check if samsung,s5kjn5 has an upstream binding in Documentation/devicetree/bindings/media/i2c/
  • If yes, backport the binding YAML file in a separate commit before this DTS change

Option 2 (if no binding exists):

  • Create Documentation/devicetree/bindings/media/i2c/samsung,s5kjn5.yaml following the kernel DT binding schema format
  • Submit as a separate commit before the DTS change
  • Ensure the samsung vendor prefix exists in vendor-prefixes.yaml (it likely already does)

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git 1110d788f08fefe87c7e387e613d4d72c50b7eb8..57854f43bb896b6415c42afe4ec5c4040e5e58a2

❌ check-patch-compliance

Root cause: The commit subject uses the PENDING: prefix, which is not in the allowed list for check-patch-compliance (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:).

Failure details:

Checking commit: PENDING: arm64: media: dts: sm8750-mtp: Add s5kjn5 image sensor on CSIPHY2
Commit summary does not start with a required prefix

Analysis:

This is a known limitation of the check-patch-compliance checker. The checker enforces a strict subset of prefixes that require upstream linkage:

  • ✅ Accepted: FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:
  • ❌ Rejected: PENDING:, QCLINUX:, WORKAROUND:

The PENDING: prefix indicates work-in-progress that has not yet been posted upstream. This is a valid use case for topic branches, but the checker will always fail for such commits.

Fix options:

  1. If the patch has been posted to a mailing list:

    • Change prefix to FROMLIST:
    • Add Link: <lore.kernel.org URL> to the commit message body
  2. If this is vendor-only and will not be posted upstream:

    • Change prefix to QCLINUX: (but note: this will also fail check-patch-compliance)
    • Accept that check-patch-compliance will fail for vendor-only commits
  3. If this is genuinely pending and not yet posted:

    • Keep PENDING: prefix
    • Accept that check-patch-compliance will fail
    • This is a known checker limitation for work-in-progress commits

Note: The tag-check (Step 2.7 of the skill) passes because PENDING: is a valid subject-line prefix for all branches except qcom-next and qcom-next-staging. The target branch tech/all/dt/pakala requires a prefix, and PENDING: satisfies that requirement.


Verdict

2 blockers to address before merge:

  1. checkpatch warning (mandatory fix): Add DT binding documentation for samsung,s5kjn5 or backport existing upstream binding
  2. check-patch-compliance failure (policy decision): Either post the patch upstream and change to FROMLIST: + add Link:, or accept that PENDING:/vendor-only commits will fail this checker

Recommendation:

  • If the S5KJN5 sensor binding exists upstream, backport it in a separate commit
  • If not, create the binding YAML following kernel DT schema conventions
  • For the PENDING: prefix issue: if this patch will be posted upstream soon, wait and use FROMLIST: + Link:; otherwise, accept the checker limitation for work-in-progress commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants