Skip to content

[mypyc] Fix flaky test - #22527

Merged
JukkaL merged 1 commit into
masterfrom
mypyc-fix-flaky-test
Nov 19, 2026
Merged

JukkaL merged 1 commit into
masterfrom
mypyc-fix-flaky-test

Conversation

@JukkaL

@JukkaL JukkaL commented Nov 19, 2026

Copy link
Copy Markdown
Collaborator

The test case testTracebackCodeObjectReuse added in #22476 randomly failed when there was a hash collision. Use just one entry so that there can't be a collision.

Run the updated test case 2000 times and it always passed locally, whereas the original test failed 4 times out of 2000.

Example failure: https://github.com/python/mypy/actions/runs/44559064375/job/135683016962?pr=22526

The test case `testTracebackCodeObjectReuse` added in #22476 randomly
failed when there was a hash collision. Use just one entry so that
there can't be a collision.

Run the updated test case 2000 times and it always passed locally,
whereas the original test failed 4 times out of 2000.
@JukkaL
JukkaL merged commit 295e3aa into master Nov 19, 2026
18 checks passed
@JukkaL
JukkaL deleted the mypyc-fix-flaky-test branch November 19, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants