Repository navigation
[mypyc] Fix bad C for attribute names that are C keywords when mangled - #22526
Merged
Merged
Conversation
…ngled Fixes mypyc/mypyc#1217. Fixes mypyc/mypyc#1187. The C struct field name of a native attribute is the attribute name with a "_" prefix, which can produce a C keyword or some other name reserved by C compilers, resulting in confusing C compilation errors: ```python class C: def __init__(self) -> None: self._restrict = 0 # Field "__restrict" is a keyword in gcc/clang ``` Many names names were affected. Now if the prefixed name is reserved by the C standard (it starts with two underscores or an underscore followed by an uppercase letter) or is a known MSVC keyword, an additional "m" prefix is used. This can't collide with other field names, since they all start with "_".
p-sawicki
approved these changes
Nov 19, 2026
Collaborator
Author
|
The test failure is a flake (I'm working on a fix). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes mypyc/mypyc#1217. Fixes mypyc/mypyc#1187.
The C struct field name of a native attribute is the attribute name with a "_" prefix, which can produce a C keyword or some other name reserved by C compilers, resulting in confusing C compilation errors:
Many names names were affected.
Now if the prefixed name is reserved by the C standard (it starts with two underscores or an underscore followed by an uppercase letter) or is a known MSVC keyword, an additional "m" prefix is used. This can't collide with other field names, since they all start with "_".