Repository navigation
Fix false unreachable warnings for sequence patterns over tuple unions - #22517
Closed
Sudhakar7J wants to merge 1 commit into
Closed
Sudhakar7J wants to merge 1 commit into
Sudhakar7J wants to merge 1 commit into
Conversation
…atching When matching sequence patterns against union types, avoid reporting impossible-intersection diagnostics for individual non-matching union alternatives. Fixes python#22150
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Author
|
CI update: all checks have completed successfully except This appears unrelated to this PR, which only adjusts per-alternative error filtering during sequence-pattern union matching in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a sequence pattern is checked against a union of tuple types,
PatternChecker.visit_sequence_patternevaluates the pattern against each union alternative. For alternatives that do not match,conditional_types_with_intersectioncan emit impossible-intersection diagnostics (reported as[unreachable]with--warn-unreachable) even though the overall case is reachable via other union members.This suppresses diagnostics while matching individual union alternatives in the sequence-pattern decomposition path, preserving the computed match/rest/capture types.
Fixes #22150
Test Plan
testMatchSequencePatternUnionTupleNoUnreachableintest-data/unit/check-python310.test(--warn-unreachable,fixtures/tuple.pyi) coveringtuple[None, int] | tuple[int, None] | tuple[int, int]with(None, int(y)),(int(x), None),(int(x), int(y)).unreachableforNonesub-pattern when matching a union of tuples #22150 reportsSuccess: no issues foundwith--warn-unreachable --strict.uv run):pytest -n0 -k testMatchSequencePatternUnionTupleNoUnreachable mypy/test/testcheck.py— 1 passedpytest -n0 -k "MatchSequencePattern or testMatchSequence" mypy/test/testcheck.py— 34 passed, 8359 deselected