Skip to content

[mypyc] Use registers from setUp in emitfunc tests - #22481

Merged
p-sawicki merged 1 commit into
python:masterfrom
Jahongir-Qurbonov:mypyc-emitfunc-test-registers
Nov 20, 2026
Merged

p-sawicki merged 1 commit into
python:masterfrom
Jahongir-Qurbonov:mypyc-emitfunc-test-registers

Conversation

@Jahongir-Qurbonov

Copy link
Copy Markdown
Contributor

test_long_unsigned, test_long_signed and test_extend in test_emitfunc.py created their own int64/int32 registers named a, although setUp already defines self.i64 and self.i32 registers for this purpose and the other tests use them. Use those instead. This is a test-only cleanup with no functional changes.

(This touches the same lines in test_extend as #22479, so I'll merge master into whichever lands second.)

test_long_unsigned, test_long_signed and test_extend created their own
int64 and int32 registers, although setUp already defines i64 and i32
registers for this purpose. Use those instead, like the other tests.

@p-sawicki p-sawicki left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@p-sawicki
p-sawicki merged commit 1572a18 into python:master Nov 20, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants