Repository navigation
[mypyc] Use registers from setUp in emitfunc tests - #22481
Merged
p-sawicki merged 1 commit intoNov 20, 2026
Merged
Conversation
test_long_unsigned, test_long_signed and test_extend created their own int64 and int32 registers, although setUp already defines i64 and i32 registers for this purpose. Use those instead, like the other tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_long_unsigned,test_long_signedandtest_extendintest_emitfunc.pycreated their ownint64/int32registers nameda, althoughsetUpalready definesself.i64andself.i32registers for this purpose and the other tests use them. Use those instead. This is a test-only cleanup with no functional changes.(This touches the same lines in
test_extendas #22479, so I'll merge master into whichever lands second.)