Repository navigation
[mypyc] Add primitives for int and bytes containment in bytes - #22409
Merged
Merged
Conversation
13 of 14 tasks
# Conflicts: # mypyc/test-data/run-bytes.test
Collaborator
|
This PR has merge conflicts, please rebase. |
# Conflicts: # mypyc/test-data/irbuild-bytes.test # mypyc/test-data/run-bytes.test
JukkaL
approved these changes
Nov 19, 2026
JukkaL
left a comment
Collaborator
There was a problem hiding this comment.
Looks good! I have an idea about how to further improve performance in some cases -- I'll prepare a follow-up PR.
JukkaL
added a commit
that referenced
this pull request
Nov 20, 2026
…22528) The memchr + memcmp search that was added in #22409 is fast on typical data, but when the first byte to search for is frequent, each iteration makes little progress. This seems fairly common, but in the worst case this was ~9x slower than CPython. Fall back to CPython search algorithm if there are many first byte hits that don't match the whole search string. On Python 3.10 we need to fall back to PySequence_Contains, but on newer versions there is a private CPython API we can use. Benchmark results on Linux x86-64 (time relative to master, lower is better): * 1 MB Python source, `b" raise NotImplemented!"` (miss): 0.12x * `b"a" * 100_000`, `b"ab"` (miss): 0.11x * Short inputs (8-80 bytes): 0.86-0.99x The worst case is a dense region followed by a long sparse one, e.g. `b"a" * 200 + b"x" * 1_000_000` and `b"ab"`, which is now about as slow as the generic CPython search (~35x slower than master).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add primitives for
x in b/x not in bwherebisbytesandxisintorbytes.Previously these used
PySequence_Contains. For abytesitem that is particularly slow, sincebytes.__contains__first tries to convert the item to an integer, which raises and clears aTypeError, and then acquires a buffer.int in bytes: for an exactbytesobject, a range check followed bymemchr. Out-of-range values raise the sameValueErroras CPython.bytes in bytes: if both are exactbytesobjects and the needle is at most 32 bytes long, search directly usingmemchr+memcmp. Longer needles fall back to the generic implementation, which has better worst-case behavior.__contains__) use the generic path.Tests compare the results against the generic implementation (through
Any) for all byte values, out-of-range and big ints, and all substrings (plus near-miss variants) of several haystacks.Micro-benchmark (compiled code, before -> after, Python 3.13):
int in bytes(3.2M checks): 0.025s -> 0.0086sbytes in bytes(3.2M checks): 0.49s -> 0.026sbytes in bytes(3.2M checks): 0.49s -> 0.039sPart of mypyc/mypyc#644.