Skip to content

gh-155170: Expose extension compiler flags in build details #155172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pablogsal wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gh-155170: Expose extension compiler flags in build details #155172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions Lib/test/test_build_details.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import json
import os
import os.path
import shlex
import sys
import sysconfig
import string
Expand Down Expand Up @@ -173,6 +174,13 @@ def test_c_api(self):
version = sysconfig.get_config_var('VERSION')
self.assertTrue(os.path.exists(os.path.join(value['pkgconfig_path'], f'python-{version}.pc')))

def test_extension_compiler_flags(self):
value = self.key('arbitrary_data.extension_compiler_flags')
expected = shlex.split(
sysconfig.get_config_var('FRAME_POINTER_CFLAGS') or ''
)
self.assertEqual(value, expected)


@unittest.skipIf(
generate_build_details is None,
Expand Down
1 change: 1 addition & 0 deletions Makefile.pre.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ MAKESETUP= $(srcdir)/Modules/makesetup
# Compiler options
OPT= @OPT@
BASECFLAGS= @BASECFLAGS@
FRAME_POINTER_CFLAGS= @FRAME_POINTER_CFLAGS@
BASECPPFLAGS= @BASECPPFLAGS@
CONFIGURE_CFLAGS= @CFLAGS@
# CFLAGS_NODIST is used for building the interpreter and stdlib C extensions.
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Build/2026-08-04-12-00-00.gh-issue-155170.abc123.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Expose CPython's frame-pointer flags for extension builds in
``build-details.json``.
3 changes: 3 additions & 0 deletions PC/layout/support/builddetails.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,9 @@
},
"c_api": {
},
"arbitrary_data": {
"extension_compiler_flags": [],
},
}


Expand Down
6 changes: 6 additions & 0 deletions Tools/build/generate-build-details.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
import importlib.machinery
import json
import os
import shlex
import sys
import sysconfig

Expand Down Expand Up @@ -129,6 +130,11 @@ def generate_data(schema_version: str) -> collections.defaultdict[str, Any]:
if LIBPC:
data['c_api']['pkgconfig_path'] = LIBPC

frame_pointer_cflags = sysconfig.get_config_var('FRAME_POINTER_CFLAGS') or ''
data['arbitrary_data']['extension_compiler_flags'] = shlex.split(
frame_pointer_cflags
)

return data


Expand Down
6 changes: 5 additions & 1 deletion configure
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2620,6 +2620,8 @@ AC_ARG_WITH([frame-pointers],
[with_frame_pointers=yes])
AC_MSG_RESULT([$with_frame_pointers])

AC_SUBST([FRAME_POINTER_CFLAGS])
FRAME_POINTER_CFLAGS=
AS_VAR_IF([ac_cv_gcc_compat], [yes], [
dnl Keep frame pointers in CPython, stdlib objects, and third-party
dnl extensions built against this Python (BASECFLAGS propagates via
Expand Down Expand Up @@ -2651,7 +2653,8 @@ AS_VAR_IF([ac_cv_gcc_compat], [yes], [
])
], [], [-Werror])
if test -n "$frame_pointer_cflags" && test "x$with_frame_pointers" != xno; then
BASECFLAGS="$frame_pointer_cflags $BASECFLAGS"
FRAME_POINTER_CFLAGS="$frame_pointer_cflags"
BASECFLAGS="$FRAME_POINTER_CFLAGS $BASECFLAGS"
AC_DEFINE([_Py_WITH_FRAME_POINTERS], [1],
[Define to 1 if frame unwinding via pointers is expected
to work, 0 if not. Leave undefined if unknown.])
Expand Down
Loading