gh-152548: Report a subprocess of runInSubprocess() dying after the test - #155162
Merged
serhiy-storchaka merged 1 commit intoAug 4, 2026
Merged
Conversation
… the test The subprocess writes the result of the test before exiting, so a crash during interpreter finalization left the result intact and the test was reported as passed. Check the exit code too, after replaying the outcomes, so that a failure of the test itself is still reported as a failure. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
serhiy-storchaka
added
needs backport to 3.13
serhiy-storchaka
added
the
needs backport to 3.15
serhiy-storchaka
enabled auto-merge (squash)
August 4, 2026 09:57
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
|
GH-155167 is a backport of this pull request to the 3.15 branch. |
bedevere-app
Bot
removed
the
needs backport to 3.15
|
GH-155168 is a backport of this pull request to the 3.14 branch. |
|
GH-155169 is a backport of this pull request to the 3.13 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Aug 4, 2026
…r the test (GH-155162) (GH-155169) The subprocess writes the result of the test before exiting, so a crash during interpreter finalization left the result intact and the test was reported as passed. Check the exit code too, after replaying the outcomes, so that a failure of the test itself is still reported as a failure. (cherry picked from commit ef0affb) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
serhiy-storchaka
added a commit
that referenced
this pull request
Aug 4, 2026
…r the test (GH-155162) (GH-155168) The subprocess writes the result of the test before exiting, so a crash during interpreter finalization left the result intact and the test was reported as passed. Check the exit code too, after replaying the outcomes, so that a failure of the test itself is still reported as a failure. (cherry picked from commit ef0affb) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The subprocess writes the result of the test before exiting, so a crash during
interpreter finalization was not noticed and the test was reported as passed.
Check the exit code too, after replaying the outcomes, so that a failure of the
test itself is still reported as a failure.