-
-
Notifications
You must be signed in to change notification settings - Fork 35.1k
gh-155087: Add ternary conditional operator (?:) and $-prefix None-declaration syntax #155089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b156e63
New features calle ternary and declaration
rajdeepdeyon2022-hub cae3525
New changes
rajdeepdeyon2022-hub 594b91f
Add dollar-declaration () syntax and assignment-aware ternary (?:) op…
rajdeepdeyon2022-hub 136490f
Finalize grammar and token changes
rajdeepdeyon2022-hub 97998dd
Add dollar-declaration () syntax and assignment-aware ternary (?:) op…
rajdeepdeyon2022-hub 4e3560f
Merge clean grammar changes into features
rajdeepdeyon2022-hub 36151f5
Merge branch 'main' into features
RAJ0793 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -59,6 +59,8 @@ RARROW '->' | |
| ELLIPSIS '...' | ||
| COLONEQUAL ':=' | ||
| EXCLAMATION '!' | ||
| DOLLAR '$' | ||
| TERNARY '?' | ||
|
|
||
| OP | ||
| TYPE_IGNORE | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When callers parse with an older grammar via
PyCF_ONLY_AST/ast.parse(..., feature_version=(3, 15)), this rule still acceptsa ? b : cbecause it constructsIfExpdirectly instead of usingCHECK_VERSION. Since this tree is already Python 3.16 (PY_MINOR_VERSIONis 16), the new?:syntax (and the new$statement rule) should be wrapped in a version check so tools that request an older grammar continue to reject it.Useful? React with 👍 / 👎.