[3.15] gh-154902: Type-check the SET_ADD operand

[deadlovelll]

Type-check the SET_ADD operand

This is an alternative version of fix for #154902, but dedicated to 3.15 and 3.14 only, because we cant change bytecode here

• Issue: Assigning __conditional_annotations__ crashes the interpreter #154902

[deadlovelll]

Looked at the checks, I think these are flakes. Could someone with the rights rerun the failed jobs?

[JelleZijlstra]

Error message shouldn't mention __conditional_annotations__ as this is a generic opcode (though probably the only way this is reachable is through __conditional_annotations__).

[deadlovelll]

Changed

[JelleZijlstra]

Thoughts on whether this should be CheckExact?

[deadlovelll]

missed that it applies here too , changed to CheckExact

[bedevere-bot]

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 CentOS9 NoGIL Refleaks 3.15 (tier-1) has failed when building commit 398dbef.

What do you need to do:

1. Don't panic.
2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/2078/builds/383) and take a look at the build logs.
4. Check if the failure is related to this commit (398dbef) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/2078/builds/383

Failed tests:

• test_lazy_import

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.15.itamaro-centos-aws.refleak.nogil/build/Lib/test/test_lazy_import/__init__.py", line 1828, in test_concurrent_lazy_import_reification
    self.assertEqual(errors, [], f"Errors occurred: {errors}")
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: Lists differ: [(3, AttributeError("module 'test.test_laz[39 chars]'"))] != []


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.15.itamaro-centos-aws.refleak.nogil/build/Lib/test/test_lazy_import/__init__.py", line 1828, in test_concurrent_lazy_import_reification
    self.assertEqual(errors, [], f"Errors occurred: {errors}")
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: Lists differ: [(0, AttributeError("module 'test.test_laz[39 chars]'"))] != []

[hugovk]

I think that is an unrelated failure, looks like:

• test_concurrent_lazy_import_reification is flaky #154561
• gh-154561: Check module dict after trying to load submodule #154742

[deadlovelll]

I think that is an unrelated failure, looks like:

• test_concurrent_lazy_import_reification is flaky #154561

• gh-154561: Check module dict after trying to load submodule #154742

Yeah, not related to this pr