Repository navigation
Release: check that the tag matches the version in setup.cfg - #217
Open
luizfnsilva wants to merge 1 commit into
Open
luizfnsilva wants to merge 1 commit into
luizfnsilva wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
Maybe setuptools-scm ought to be useful instead But that needs a maintainers decision |
Author
|
That makes sense. setuptools-scm could be a good fit if the maintainers want to derive the package version directly from Git. My proposal is narrower: keep the existing release process and fail early if the tag and the declared package version disagree. Happy to leave the architectural choice to the maintainers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2.5.0 was tagged before the version bump (945ec46 declares 2.4.0 in setup.cfg; 16edd49 bumps it
after the tag). Since #202 the Release workflow builds from the release tag, so the same slip
would now build and publish whatever setup.cfg says.
This adds one step before the build: it fails the job when the tag name and the
versionline insetup.cfg differ. Nothing else changes; RELEASING.rst already says to bump first.
🤖 Generated with Claude Code