Repository navigation
Conversation
Use explicit elided lifetime placeholders on the HintRef return type so the lifetime relationships are clear and the compiler warning is removed. Fixes pyrefly-org#5590.
jay23606
marked this pull request as ready for review
November 14, 2026 18:55
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the lifetime parameters on
HintRefexplicit inas_hint_for_display, removing the inconsistent lifetime syntax warning from issue #5590.Fixes #5590
Test Plan
rustfmt --check pyrefly/lib/alt/operators.rs— passed.cargo check -p pyrefly— not completed locally; dependency fetching stalled. Draft CI is needed to confirm the compiler warning is gone.