Skip to content

Respect model-level strict config in synthesized RootModel __init__ #5649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
soaring0616 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Respect model-level strict config in synthesized RootModel __init__ #5649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pyrefly/lib/alt/class/dataclass.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,11 @@ impl<'ctx, 'answer, Ans: LookupAnswer> AnswersSolver<'ctx, 'answer, Ans> {
let init_method = if let Some((root_model_type, has_strict)) =
self.get_pydantic_root_model_type_via_mro(cls, metadata)
{
self.get_pydantic_root_model_init(cls, root_model_type, has_strict)
self.get_pydantic_root_model_init(
cls,
root_model_type,
has_strict || dataclass.kws.strict,
)
} else if metadata.is_pydantic_model() {
// Pydantic models with RootModel fields need type expansion
let transform_type: &dyn Fn(Type) -> Type = &|ty: Type| {
Expand Down
21 changes: 21 additions & 0 deletions pyrefly/lib/test/pydantic/root_model.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,3 +350,24 @@ def serialize(d: InnerModelDict) -> OuterModel:
return OuterModel(data=d)
"#,
);

pydantic_testcase!(
test_root_model_config_strict,
r#"
from pydantic import ConfigDict, RootModel

class Text(RootModel[str]):
model_config = ConfigDict(strict=True)

class Text2(RootModel[str], strict=True): ...

class Child(Text): ...

class Lax(RootModel[str]): ...

Text(b"hello") # E: Argument `Literal[b'hello']` is not assignable to parameter `root` with type `str`
Text2(b"hello") # E: Argument `Literal[b'hello']` is not assignable to parameter `root` with type `str`
Child(b"hello") # E: Argument `Literal[b'hello']` is not assignable to parameter `root` with type `str`
Lax(b"hello")
"#,
);
Loading