Repository navigation
Add hard reference to the future in CallCallable - #373
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #373 +/- ##
==========================================
- Coverage 85.05% 85.04% -0.02%
==========================================
Files 49 49
Lines 3975 3971 -4
==========================================
- Hits 3381 3377 -4
Misses 594 594 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
tlambert03
approved these changes
Nov 18, 2026
tlambert03
left a comment
Member
There was a problem hiding this comment.
thanks! looks good to me. i tested on a range of qt backends and versions and it worked across all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running a test in napari it happens with the PySide6 backend to reach the deadlock. It looks like a bug in PySide6 code (wrong order of acquiring locks). But the deadlock was caused by a garbage collector that removed future instances (if I correctly understand the workflow).
The problematic schedule is:
futureobjectfuture.set_resultis not longerwalidThis PR allows omitting it by keeping a hard reference to the future object until work is done.