Repository navigation
feat: deprecate applyMacStylePatch, which does nothing with Qt 6 - #370
Open
tlambert03 wants to merge 1 commit into
Open
tlambert03 wants to merge 1 commit into
tlambert03 wants to merge 1 commit into
Conversation
Qt fixed QTBUG-98093 (sliders on macOS 12+) in 6.2.3, so with Qt 6 the style sheet workaround only restyles the slider: applyMacStylePatch() now does nothing there, with a DeprecationWarning. Qt 5 is unchanged, as are USE_MAC_SLIDER_PATCH (which only ever applied to Qt 5) and MONTEREY_SLIDER_STYLES_FIX.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #370 +/- ##
==========================================
+ Coverage 85.05% 85.06% +0.01%
==========================================
Files 49 49
Lines 3975 3985 +10
==========================================
+ Hits 3381 3390 +9
- Misses 594 595 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
tlambert03
marked this pull request as ready for review
November 14, 2026 08:08
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
applyMacStylePatch()(andMONTEREY_SLIDER_STYLES_FIX) work around QTBUG-98093: sliders not dragging properly on macOS 12+ (#74, #117). Qt fixed that in 6.2.3, and we require Qt >= 6.4 anyway ... so with Qt 6 the patch doesn't fix anything, it just restyles the slider. This makesapplyMacStylePatch()a no-op on Qt 6, with aDeprecationWarning. Qt 5 is unchanged (the fix never made it into the open source 5.15 releases, as far as I can tell).USE_MAC_SLIDER_PATCHis unchanged: it only ever applied to Qt 5 (and macOS 12+)MONTEREY_SLIDER_STYLES_FIXstays, as a plain constant (napari-prism applies it directly)The main caller is magicgui, which applied it to every range slider on any Qt and OS: pyapp-kit/magicgui#752 limits that to Qt 5 on macOS 12+.