Skip to content

build: drop Python 3.10 and test cp315 wheels - #445

Merged
tlambert03 merged 2 commits into
pyapp-kit:mainfrom
jacopoabramo:build/drop-python-3.10
Nov 19, 2026
Merged

tlambert03 merged 2 commits into
pyapp-kit:mainfrom
jacopoabramo:build/drop-python-3.10

Conversation

@jacopoabramo

@jacopoabramo jacopoabramo commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Bumps Python minimum version to 3.11 and tests against 3.15 (which can now be done since pydantic 2.14 is out).

I'm making this PR in preparation of some work I'm doing to support typed signals (a PR based off #304 but requires some discussion + a new mypy release)

EDIT: AI disclosure, assisted with Opus 5.5

@codspeed

codspeed Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

1 warning

⚠️ 4 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

✅ 67 untouched benchmarks


Comparing jacopoabramo:build/drop-python-3.10 (437a59f) with main (8a1c2df)

Open in CodSpeed

@jacopoabramo

Copy link
Copy Markdown
Contributor Author

437a59f fixes the typing job which was also failing on main.

GitHub's runners now come with Python 3.14, and pytest-mypy-plugins was set to install only below 3.14, so the job ran without it. The plugin supports 3.14 since version 3.3.0, so I removed that limit. The typing tests should pass on 3.14 with it. I verified locally but waiting on CI to confirm

@codecov

codecov Bot commented Nov 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.68%. Comparing base (8a1c2df) to head (437a59f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #445      +/-   ##
==========================================
- Coverage   99.76%   99.68%   -0.08%     
==========================================
  Files          23       23              
  Lines        2559     2559              
==========================================
- Hits         2553     2551       -2     
- Misses          6        8       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tlambert03

Copy link
Copy Markdown
Member

do you specifically need us to drop 3.10? Or just doing housekeeping for us? since psygnal is probably the most broadly used library in this org, i allow it to be a little bit extended in its support for "just EOL" things like 3.10. if there are features you specifically want to be able to support, can we have a discussion about them first?

@jacopoabramo

Copy link
Copy Markdown
Contributor Author

Did a quick check and fortunately no!, doesn't seem that generic signals requires dropping 3.10. So I'll close this and open the actual PR

@jacopoabramo
jacopoabramo deleted the build/drop-python-3.10 branch November 16, 2026 14:08
@tlambert03

Copy link
Copy Markdown
Member

after looking at #446 (which i'm excited about!) I'm happy to accept this PR and drop 3.10. feel free to reopen it. i know it just lets you drop a small shim... but it's fine and cleaner. and it is EOL. so fine with me.

@jacopoabramo
jacopoabramo restored the build/drop-python-3.10 branch November 17, 2026 12:15
@jacopoabramo jacopoabramo reopened this Nov 17, 2026
@jacopoabramo

jacopoabramo commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor Author

@tlambert03 thanks, this is ready to get merged. I'll rebase #446 once it's in.

FYI, selfishly, I would ask if it's possible to make a release prior to these 2 PRs, there are a couple of fixes / features (#439 and #441) that I could already apply to my codebase. I don't know how much is changed and warrants a 0.17.0, based on those 2 PRs a 0.16.2 would suffice I guess. Not urgent, eh! I can live without it if you wish to be more conservative.

@tlambert03

Copy link
Copy Markdown
Member

all set https://github.com/pyapp-kit/psygnal/releases/tag/v0.17.0

@jacopoabramo

Copy link
Copy Markdown
Contributor Author

Wonderful, thanks. I double checked and this can be merged at your best convenience

compile: ["1", "0"]
qt: [""]
include:
- os: ubuntu-latest

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why it would be dropping this include?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because python-version 3.10 was changed to 3.11 so it will be a duplicate.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah of course! Thanks:)

@tlambert03
tlambert03 merged commit 08ef9eb into pyapp-kit:main Nov 19, 2026
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants