Repository navigation
build: drop Python 3.10 and test cp315 wheels - #445
Conversation
Merging this PR will not alter performance1 warning
Comparing |
|
437a59f fixes the GitHub's runners now come with Python 3.14, and |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #445 +/- ##
==========================================
- Coverage 99.76% 99.68% -0.08%
==========================================
Files 23 23
Lines 2559 2559
==========================================
- Hits 2553 2551 -2
- Misses 6 8 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
do you specifically need us to drop 3.10? Or just doing housekeeping for us? since psygnal is probably the most broadly used library in this org, i allow it to be a little bit extended in its support for "just EOL" things like 3.10. if there are features you specifically want to be able to support, can we have a discussion about them first? |
|
Did a quick check and fortunately no!, doesn't seem that generic signals requires dropping 3.10. So I'll close this and open the actual PR |
|
after looking at #446 (which i'm excited about!) I'm happy to accept this PR and drop 3.10. feel free to reopen it. i know it just lets you drop a small shim... but it's fine and cleaner. and it is EOL. so fine with me. |
|
@tlambert03 thanks, this is ready to get merged. I'll rebase #446 once it's in. FYI, selfishly, I would ask if it's possible to make a release prior to these 2 PRs, there are a couple of fixes / features (#439 and #441) that I could already apply to my codebase. I don't know how much is changed and warrants a 0.17.0, based on those 2 PRs a 0.16.2 would suffice I guess. Not urgent, eh! I can live without it if you wish to be more conservative. |
|
Wonderful, thanks. I double checked and this can be merged at your best convenience |
| compile: ["1", "0"] | ||
| qt: [""] | ||
| include: | ||
| - os: ubuntu-latest |
There was a problem hiding this comment.
Do you know why it would be dropping this include?
There was a problem hiding this comment.
Because python-version 3.10 was changed to 3.11 so it will be a duplicate.
Bumps Python minimum version to 3.11 and tests against 3.15 (which can now be done since pydantic 2.14 is out).
I'm making this PR in preparation of some work I'm doing to support typed signals (a PR based off #304 but requires some discussion + a new mypy release)
EDIT: AI disclosure, assisted with Opus 5.5