Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/magicgui/backends/_qtpy/widgets.py
Original file line number Diff line number Diff line change
Expand Up @@ -848,7 +848,12 @@ def __init__(self, qwidg=QtW.QSlider, **kwargs: Any) -> None:

no_buttons = QtW.QAbstractSpinBox.ButtonSymbols.NoButtons
self._readout_widget.setButtonSymbols(no_buttons)
self._readout_widget.setStyleSheet("background:transparent; border: 0;")
# style the inner line edit rather than the spinbox itself: on Qt 6.12, a
# `border` rule on a button-less spinbox shrinks its line edit to 1px (#750)
self._readout_widget.setFrame(False)
self._readout_widget.lineEdit().setStyleSheet(
"background:transparent; border: 0;"
)

self._qwidget.valueChanged.connect(self._on_slider_change)
self._readout_widget.editingFinished.connect(self._on_readout_change)
Expand Down
11 changes: 11 additions & 0 deletions tests/test_widgets.py
Original file line number Diff line number Diff line change
Expand Up @@ -1154,6 +1154,17 @@ def test_float_slider_readout():
assert sld._widget._readout_widget.maximum() == 10.5


@pytest.mark.parametrize("cls", [widgets.Slider, widgets.FloatSlider])
def test_slider_readout_not_clipped(cls):
"""Readout text must fit in its line edit (#750: 1px wide on Qt 6.12)."""
sld = cls(value=10)
sld.show()
line_edit = sld._widget._readout_widget.lineEdit()
text_width = line_edit.fontMetrics().horizontalAdvance(line_edit.text())
assert line_edit.width() >= text_width
sld.close()


def test_toolbar():
tb = widgets.ToolBar()
tb.add_button("test", callback=lambda: None)
Expand Down
Loading