Repository navigation
feat: add support for single-color colormaps with constant mapping behavior - #140
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #140 +/- ##
=======================================
Coverage 95.90% 95.91%
=======================================
Files 168 168
Lines 2273 2278 +5
=======================================
+ Hits 2180 2185 +5
Misses 93 93 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
I think this is a valid solution to solve that the single-valued colormap did not return a constant-valued map. However, l do think it's introducing more exceptions to the Colormap model than allowing single-valued colormaps would. Given that the interpolation at calling behaviour would also work for a single valued color, and that would avoid inserting a new value and throwing away the color stop. I can open a PR for my envisioned solution, but it will take a bit of time as I'm a bit busy in other tasks 😅 |
|
Sure, I'd be happy to see it. No hurry (as long as you're not in a hurry for a fix! 😃) |
|
got @aafkegros's sign off on this :) |
closes #139
hey @aafkegros, here's one possible fix to #139. Let me know how this would work for you. And again, still happy to iterate on this