Skip to content

fix: OperatingSystem.is_* should check self, not the current OS - #292

Merged
tlambert03 merged 1 commit into
pyapp-kit:mainfrom
tlambert03:fix/os-is-properties
Nov 20, 2026
Merged

tlambert03 merged 1 commit into
pyapp-kit:mainfrom
tlambert03:fix/os-is-properties

Conversation

@tlambert03

Copy link
Copy Markdown
Member

I was re-evaluating #230, and I don't think the original issue warrants this new public API... but #230 did have a good bug fix, which is included here with a tiny regression test.

@codecov

codecov Bot commented Nov 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.49%. Comparing base (cbd06be) to head (79698ba).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #292   +/-   ##
=======================================
  Coverage   99.49%   99.49%           
=======================================
  Files          31       31           
  Lines        1970     1970           
=======================================
  Hits         1960     1960           
  Misses         10       10           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tlambert03
tlambert03 merged commit 939ee7a into pyapp-kit:main Nov 20, 2026
42 checks passed
@tlambert03
tlambert03 deleted the fix/os-is-properties branch November 20, 2026 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant