Skip to content

Better disconnect cleanup on qmenus - #160

Closed
tlambert03 wants to merge 2 commits into
pyapp-kit:mainfrom
tlambert03:better-disconnect
Closed

tlambert03 wants to merge 2 commits into
pyapp-kit:mainfrom
tlambert03:better-disconnect

Conversation

@tlambert03

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecov Bot commented Nov 14, 2023 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.83%. Comparing base (f92ce8d) to head (b34d7af).
⚠️ Report is 82 commits behind head on main.

Files with missing lines Patch % Lines
src/app_model/registries/_menus_reg.py 66.66% 2 Missing ⚠️

❌ Your patch check has failed because the patch coverage (84.61%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #160      +/-   ##
===========================================
- Coverage   100.00%   99.83%   -0.17%     
===========================================
  Files           31       31              
  Lines         1782     1785       +3     
===========================================
  Hits          1782     1782              
- Misses           0        3       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tlambert03

Copy link
Copy Markdown
Member Author

superceded by #291

@tlambert03 tlambert03 closed this Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant