Skip to content

fix(actions): serve the build composite action from actions/ - #57

Open
kieronlanning wants to merge 1 commit into
mainfrom
actions-path
Open

kieronlanning wants to merge 1 commit into
mainfrom
actions-path

Conversation

@kieronlanning

Copy link
Copy Markdown
Contributor

Why

A cross-repository reference into a .github/actions/ path does not resolve, whatever the documentation said. aspire-resourcekit's PR workflow used the documented form and the job died in Set up job:

Download action repository 'purview-dev/build@main' (SHA:104d257…)
##[error]Can't find 'action.yml', 'action.yaml' or 'Dockerfile' for action
'purview-dev/build/.github/actions/purview-build@main'.

The manifest is present in the tree at that SHA (blob 2796f99, since 2026-11-02), so the path, not the file, is the problem. purview-build was the only action here under .github/actions; dotnet-sdk, nuget-sources, prune-github-packages and purview-release live under actions/ and resolve for every consumer. Other organisations hit the identical failure with .github/actions references.

What changed

  • git mv .github/actions/purview-build actions/purview-build — next to the four actions that work.
  • Every surface that named the old path: README.md, docs/wiki/Home.md, docs/wiki/Architecture.md (the surface table, plus a paragraph recording the constraint so it is not moved back), docs/wiki/Getting-Started.md, skills/purview-build-adoption/SKILL.md, AGENTS.md, .github/dependabot.yml, and the manifest path constants in WorkflowParityTests and NuGetSourceSetupTests.
  • Architecture.md also corrected a stale claim that this repository dogfoods the helpers from ./.github/actions/…; its workflows use ./actions/….

Compatibility

Nothing referenced the action: all seven consumers call the reusable workflow, and this repository's own workflows use ./actions/… for the helpers. The one consumer that did reference it (aspire-resourcekit) now uses purview-build.yml with aspire-cli: true from #56, so no caller breaks.

Verification

  • just test-unit — 1122/1122 and 18/18 (repository/skill conformance)
  • just test "/*/*/WorkflowParityTests/*|/*/*/NuGetSourceSetupTests/*" — 74/74
  • just lint-check — clean, including actionlint

A cross-repository reference into a .github/actions/ path does not
resolve: the runner downloads the action repository, then fails the job at
"Set up job" with "Can't find 'action.yml' ... for action
'purview-dev/build/.github/actions/purview-build@main'", even though the
manifest is present in the tree at the resolved SHA. It was the only
action here under .github/actions and the only one that fails; the four
under actions/ (dotnet-sdk, nuget-sources, prune-github-packages,
purview-release) resolve for every consumer.

Move it to actions/purview-build and update everything that names the old
path: README, Home, Architecture, Getting-Started, the adoption skill,
AGENTS.md, the Dependabot directory, and the two tests that read the
manifest. No consumer referenced it yet - the one that did,
aspire-resourcekit's PR workflow, now calls the reusable workflow with
aspire-cli instead.

Architecture records the constraint so the action is not moved back.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant