Repository navigation
fix(actions): serve the build composite action from actions/ - #57
Open
kieronlanning wants to merge 1 commit into
Open
kieronlanning wants to merge 1 commit into
kieronlanning wants to merge 1 commit into
Conversation
A cross-repository reference into a .github/actions/ path does not resolve: the runner downloads the action repository, then fails the job at "Set up job" with "Can't find 'action.yml' ... for action 'purview-dev/build/.github/actions/purview-build@main'", even though the manifest is present in the tree at the resolved SHA. It was the only action here under .github/actions and the only one that fails; the four under actions/ (dotnet-sdk, nuget-sources, prune-github-packages, purview-release) resolve for every consumer. Move it to actions/purview-build and update everything that names the old path: README, Home, Architecture, Getting-Started, the adoption skill, AGENTS.md, the Dependabot directory, and the two tests that read the manifest. No consumer referenced it yet - the one that did, aspire-resourcekit's PR workflow, now calls the reusable workflow with aspire-cli instead. Architecture records the constraint so the action is not moved back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A cross-repository reference into a
.github/actions/path does not resolve, whatever the documentation said.aspire-resourcekit's PR workflow used the documented form and the job died in Set up job:The manifest is present in the tree at that SHA (blob
2796f99, since 2026-11-02), so the path, not the file, is the problem.purview-buildwas the only action here under.github/actions;dotnet-sdk,nuget-sources,prune-github-packagesandpurview-releaselive underactions/and resolve for every consumer. Other organisations hit the identical failure with.github/actionsreferences.What changed
git mv .github/actions/purview-build actions/purview-build— next to the four actions that work.README.md,docs/wiki/Home.md,docs/wiki/Architecture.md(the surface table, plus a paragraph recording the constraint so it is not moved back),docs/wiki/Getting-Started.md,skills/purview-build-adoption/SKILL.md,AGENTS.md,.github/dependabot.yml, and the manifest path constants inWorkflowParityTestsandNuGetSourceSetupTests.Architecture.mdalso corrected a stale claim that this repository dogfoods the helpers from./.github/actions/…; its workflows use./actions/….Compatibility
Nothing referenced the action: all seven consumers call the reusable workflow, and this repository's own workflows use
./actions/…for the helpers. The one consumer that did reference it (aspire-resourcekit) now usespurview-build.ymlwithaspire-cli: truefrom #56, so no caller breaks.Verification
just test-unit— 1122/1122 and 18/18 (repository/skill conformance)just test "/*/*/WorkflowParityTests/*|/*/*/NuGetSourceSetupTests/*"— 74/74just lint-check— clean, including actionlint