Skip to content

Add kwargs parameter to extra fields methods - #8123

Merged
pedro-psb merged 1 commit into
mainfrom
dralley-patch-1
Sep 22, 2026
Merged

pedro-psb merged 1 commit into
mainfrom
dralley-patch-1

Conversation

@dralley

@dralley dralley commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

📜 Checklist

  • Commits are cleanly separated with meaningful messages (simple features and bug fixes should be squashed to one commit)
  • A changelog entry or entries has been added for any significant changes
  • Follows the Pulp policy on AI Usage
  • (For new features) - User documentation and test coverage has been added

See: Pull Request Walkthrough

@pedro-psb
pedro-psb enabled auto-merge (rebase) September 22, 2026 16:26
@pedro-psb
pedro-psb merged commit 861cb4f into main Sep 22, 2026
13 of 14 checks passed
@pedro-psb
pedro-psb deleted the dralley-patch-1 branch September 22, 2026 16:41
@mdellweg

Copy link
Copy Markdown
Member

Why are we doing this?

@dralley

dralley commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor Author

Because plugins call this method, and I want to make it possible to pass parameters, but right now that breaks completely and it's very coupled to versions. Allowing kwargs decouples it a bit, plugins can start passing values and it will at least be ignored instead of break.

The logic here isn't expected to be anything complex so that's fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants