Skip to content

Session Handoff [default]: Table Carry, Quota Safety and install-tools Shipped to Develop, Defined-Moments Review Gate #2278 Ready #2281

Description

@ptr727

Next steps, in priority order

Re-read each issue and pull request rather than trusting these summaries.

  1. Merge Request Copilot at Defined Moments and Cover Fix Pushes With an Attested Local Pass #2278, then drive the promotion. Request Copilot at Defined Moments and Cover Fix Pushes With an Attested Local Pass #2278 is the defined-moments half of Request Bot PR Reviews Judiciously, and Stop on a Quota or Rate Limit #2261, and it met the gate at head 793f50fb: status exit 0, 0 unresolved, CLEAN, checks 10/10. The maintainer merges it, since the classifier blocks an agent's gh pr merge. Then open the develop -> main promotion carrying Closes #2256, #2260, #2261, #2268, and #2272, and drive it to mergeable. Done is a promotion meeting every Merge Gate item but the maintainer's go-ahead.
  2. Apply the Copilot ruleset change fleet-wide, once Request Copilot at Defined Moments and Cover Fix Pushes With an Attested Local Pass #2278 is on main. It sets review_on_push: false and review_draft_pull_requests: false. The change is in repo-config/develop.json and main.json only, so live rulesets keep reviewing on every push until the config run applies it. That run is an outward-facing write to every fleet repository and needs the maintainer's go-ahead. The maintainer also narrows the account-level automatic-review setting in the UI.
  3. Run the Whole Test Suite Before a Push, Not the Modules a Change Touches #2280: run the whole test suite before a push. It is a governance proposal filed from this round's CI miss.
  4. Fix STANDUP.md's Prerequisite Item That Says Mechanisms Declare Environments #2270: STANDUP.md's prerequisite item. Carried. Read Session Handoff [default]: Fork Handoff Chains Released as 2.0.799, #2268 Fix on Develop #2273's "What not to repeat" first, since two rewrites drew new false claims.
  5. Carried from Session Handoff [default]: Fork Handoff Chains Released as 2.0.799, #2268 Fix on Develop #2273, in its order:

External blockers

Internal dependencies

State

The parked decision queue

Zero issues. Every question this round was answered as it arose: #2261's four design questions, the findings-count question on #2278, and the resolution of #2278's two evidence-backed declines.

What the last round did

What not to repeat

  • Running only the touched test modules. A suite-wide meta-test (test_tooling_encoding) failed in CI on Request Copilot at Defined Moments and Cover Fix Pushes With an Attested Local Pass #2278 and cost a round. Run python3 -m unittest discover -s tests from the worktree root. A module-scoped run from the root also mis-imports test_configure_model.
  • Deciding the quota stop from Q_LIVE. It carries no review bodies, so stopping_refusal never fired. The strict pass caught it, but the tests had not, because GqlCase.answer hands bodies to every query. Feed a body-less liveness payload first.
  • Mutation probes that call wait without --timeout 0. With sleep mocked they spin until the outer bound. Run each probe under setsid --wait timeout.
  • Expecting Copilot to converge on new feature code. Request Copilot at Defined Moments and Cover Fix Pushes With an Attested Local Pass #2278 drew 1 to 4 findings a round for five rounds, most of them real edge cases. The stop rule announced at round 4 held: only correctness defects in the PR's own code were fixed.

New learnings

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    handoffA link in the session handoff chain, one open issue per track

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions