fix(release): wait for npm metadata before verifying publish - #50
Merged
Merged
Conversation
Direct publish-npm verified immediately after npm accepted 1.22.1, while registry metadata still lacked dist.tarball. Poll until integrity exists, then keep the strict pack/gitHead compare. When the version is already on npm and matches the pack from cli_sha, skip publish and only complete tag/Release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause
Direct
publish-npm.ymlpublished@przeprogramowani/10x-cli@1.22.1fromd21ba2d, then immediately fetched registry metadata. npm had accepted the package (being processed) butdist.tarballwas still missing →Cannot read properties of undefined (reading 'tarball'). Tag and GitHub Release were skipped. 1.22.1 tag/Release were completed separately after byte verification; this PR is the durable path.Change
scripts/publish-npm-verify.mjs: bounded poll (backoff, 3 minute cap, attempt logs) until metadata hasdist.tarballanddist.integrity, then the same strict pack/gitHead/byte compare. Never republish on mismatch or timeout.decide: version absent → publish; already on npm and bytes matchcli_sha→ skip publish (resume tag/Release only).steps.decide.outputs.action == 'publish'. Verify always runs.Proof
Local: new tests 5/5, typecheck, lint 0 errors,
actionlintonpublish-npm.yml. No merge in this PR. No Toolkit/PR47 changes.